Pull wifi drivers and nrf_wifi changes to ncs #2519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with metadata changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
kapbh
requested review from
VivekUppunda,
ajayparida,
krish2718,
rado17 and
sachinthegreen
VivekUppunda
approved these changes
Feb 18, 2025
sachinthegreen
approved these changes
Feb 18, 2025
kapbh
force-pushed
the
changes_to_ncs
branch
from
09cc79f to
b8795c0
Compare
bama-nordic
approved these changes
Feb 23, 2025
kapbh
force-pushed
the
changes_to_ncs
branch
from
b8795c0 to
cf734c5
Compare
kapbh
force-pushed
the
changes_to_ncs
branch
4 times, most recently
from
ccd0dfe to
ad4a355
Compare
kapbh
force-pushed
the
changes_to_ncs
branch
5 times, most recently
from
2fb4434 to
f78658f
Compare
krish2718
force-pushed
the
changes_to_ncs
branch
from
156d3b2 to
8ad30d2
Compare
Update the nrf70 Wi-Fi driver to use the mode specific APIs (as a precursor to enable combining modes as required). Signed-off-by: Sachin D Kulkarni <[email protected]> (cherry picked from commit a6dfdb9)
Add test cases for SoftAP and P2P modes. Signed-off-by: Sachin D Kulkarni <[email protected]> (cherry picked from commit 522387e)
…ode. Fix compilation issues for SoftAP mode which were missed in the mode specific code changes. Signed-off-by: Sachin D Kulkarni <[email protected]> (cherry picked from commit 5f69ab7)
Pull in the latest fixes for the SAP and P2P mode builds. Signed-off-by: Sachin D Kulkarni <[email protected]> (cherry picked from commit d2e0bb2)
Add wifi_spi label to nRF54h and nRF54l dts files to help in shield overlay files Signed-off-by: Bansidhar P.M <[email protected]> (cherry picked from commit eb93df2)
Create dedicated memory pools for Wi-Fi management and data operations (defaults: 20KB for management and 130KB for data). Setting Data pool to 110KB for non-Nordic SOCs to resolve RAM overflows seen in twister runs. Remove the `HEAP_MEM_POOL_ADD_SIZE_NRF70` hint since we are creating separate heaps for driver and not allocating from system heap. Signed-off-by: Ravi Dondaputi <[email protected]> (cherry picked from commit aa0cb68)
…ry pools Pull changes for creating separate memory pools for control traffic and data traffic. Signed-off-by: Ravi Dondaputi <[email protected]> (cherry picked from commit 7f775c3)
With introduction of OSAL wrapper for memory allocation, usage of zephyr's native malloc calls need to be removed. When NRF70 driver is not enabled, OSAL needs to be built explicitly. Signed-off-by: Ravi Dondaputi <[email protected]> (cherry picked from commit 208e686)
Some file names are changed, fix file names in doxygen comments. Signed-off-by: Kapil Bhatt <[email protected]> (cherry picked from commit 46829bb)
With recent code restructuring file name and path has been changed in nrf_wifi lib. Signed-off-by: Kapil Bhatt <[email protected]> (cherry picked from commit 9285344)
… info Pull in change to include reg chan info along with reg domain in the GET_REG_DOMAIN event for the radio test and offloaded raw TX modes. Signed-off-by: Sachin D Kulkarni <[email protected]> (cherry picked from commit a34198b)
Pull in fix for CI failure in Offloaded raw TX mode caused due to commit 0cd3bb2291a7dd22f4cdb1a4cd935a213c2bbfab in nrf_wifi Signed-off-by: Sachin D Kulkarni <[email protected]> (cherry picked from commit 69ce6af)
Add prompt to Kconfig NRF70_SYSTEM_WITH_RAW_MODES. It is assigned in a configuration file, but is not directly user-configurable (has no prompt). It gets its value indirectly from other symbols. Signed-off-by: Kapil Bhatt <[email protected]> (cherry picked from commit 3ef187d)
…ents Fix doxygen comments of arguments. Signed-off-by: Kapil Bhatt <[email protected]> (cherry picked from commit 5f3bd5d)
nRF70 driver now uses a separate heap, so, no need to explicitly configure the kernel heap. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 0b8601c)
nRF70 now by default uses variale buffers. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 8fe1df6)
Fine-tune the heap to get peak UDP (TX and RX) results but with minimal heap consumption. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit be4c79b)
This uses the network packet as is without the need for a copy all the way till the packet is handed over to RPU. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 5119f9c)
Now that nRF70 by default uses zero-copy fine-tune the configuration to get optimal memory while getting peak throughputs. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit e33d9ee)
… address packets The RFC1122 section 3.3.6 says we SHOULD drop the packets if L2 address is brodcast but L3 address is unicast, but we had seen some Wi-Fi access points in the field not conforming to that, and DHCP offer is dropped due to this and causes Wi-Fi connectivity issues. As the RFC saus it's SHOULD and not a MUST, add a config option to allow such packets, disabled by default. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 4cd6654)
Add new Ethernet driver config option, ETHERNET_CONFIG_TYPE_EXTRA_TX_PKT_HEADROOM, which allows Ethernet drivers to inform L2 about the extra net_pkt headroom they need to be allocated. This is only supported when CONFIG_NET_L2_ETHERNET_RESERVE_HEADER is enabled, so that it's possible to fit entire packet into a single net_buf, which is needed for zero-copy transmission. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 78c3996)
It seems that this change was solely added to address issues with old TCP stack, which blindly queued packets intended for TX for potential further retransmission, expecting that the packet would remain intact during transmission. I think this assumption was wrong, as it's natural that lower layers append respective headers to the packet, and this "header stripping" behavior was specific for Ethernet L2 only. If an upper layer expects that the packet would need to be retransmitted at some point, it should clone it instead. Therefore, remove the L2 header stripping from the Ethernet L2 to avoid any potential issues in zero-copy case. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 21b7122)
Fix linking errors by using the Zephyr flags for libary too. Upstream PR #: 87835 Signed-off-by: Kapil Bhatt <[email protected]>
…it failures Reconfigure DATA heap sizes to fix the driver init failures. Upstream PR #: 87979 Signed-off-by: Ravi Dondaputi <[email protected]>
Add a debug shell to the driver to provide advanced debug support such as reading/writing to RPU memory and registers etc. Upstream PR #: 87823 Signed-off-by: Sachin D Kulkarni <[email protected]>
Move the wifi_util to the newly created nrf70 shell as a sub-shell. Upstream PR #: 87823 Signed-off-by: Sachin D Kulkarni <[email protected]>
krish2718
force-pushed
the
changes_to_ncs
branch
from
1096fc3 to
f2cb716
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to pull raw scan changes to NCS. Dues to conflicts, need to bring other changes also.