[nrf fromtree] Bluetooth: Host: Fix buffer allocation warnings in system workqueue #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirlenko
force-pushed
the
fix_buffer_allocation_warnings_in_system_workquue
branch
from
638c39c to
a9695c5
Compare
Mirlenko
changed the title
…tem workqueue The buffer allocation in conn.c will trigger warnings if we try to use anything else than K_NO_WAIT for the timeout when called from within the system workqueue. The calls in l2cap.c and att.c which may pass non-zero timeouts already have proper handling for failed allocations, so make sure we use K_NO_WAIT to avoid unnecessary warnings from conn.c. Signed-off-by: Johan Hedberg <[email protected]> Signed-off-by: Aleksandr Mirlenko <[email protected]> (cherry picked from commit 05b16b9)
Mirlenko
force-pushed
the
fix_buffer_allocation_warnings_in_system_workquue
branch
from
a9695c5 to
d216dad
Compare
gordonklaus
approved these changes
Feb 27, 2025
ppryga-nordic
approved these changes
Feb 27, 2025
Mirlenko
deleted the
fix_buffer_allocation_warnings_in_system_workquue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer allocation in conn.c will trigger warnings if we try to use anything else than K_NO_WAIT for the timeout when called from within the system workqueue.
The calls in l2cap.c and att.c which may pass non-zero timeouts already have proper handling for failed allocations, so make sure we use K_NO_WAIT to avoid unnecessary warnings from conn.c.
Signed-off-by: Aleksandr Mirlenko [email protected]
(cherry picked from commit 05b16b9)