net: l2: Add a config option to allow mismatched L3/L2 address packets #2575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinthegreen
approved these changes
Mar 6, 2025
… address packets The RFC1122 section 3.3.6 says we SHOULD drop the packets if L2 address is brodcast but L3 address is unicast, but we had seen some Wi-Fi access points in the field not conforming to that, and DHCP offer is dropped due to this and causes Wi-Fi connectivity issues. As the RFC saus it's SHOULD and not a MUST, add a config option to allow such packets, disabled by default. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 4cd6654)
krish2718
approved these changes
Mar 7, 2025
LuDuda
approved these changes
Mar 7, 2025
Add necessary changes for NCS CI commit tags. Signed-off-by: Kapil Bhatt <[email protected]>
Use v4 of cache to fix compliance. Signed-off-by: Kapil Bhatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC1122 section 3.3.6 says we SHOULD drop the packets if L2 address is brodcast but L3 address is unicast, but we had seen some Wi-Fi access points in the field not conforming to that, and DHCP offer is dropped due to this and causes Wi-Fi connectivity issues.
As the RFC saus it's SHOULD and not a MUST, add a config option to allow such packets, disabled by default.
Signed-off-by: Chaitanya Tata [email protected]
(cherry picked from commit 4cd6654)