Skip to content

Conversation

@tervonenja
Copy link

Fix NULL pointer to strcmp in posix mqueue.

theob-pro and others added 30 commits February 20, 2025 13:45
…ar at the end

The function used to write the value of the GAP Device Name
characteristic now ensure that the string passed to `bt_set_name` is
null terminated.

Also fix a wrong offset calculation.

The function used to write the value of the GAP Device Name
characteristic was returning an error when the offset + the length of
data to write was superior **or equal** to the maximum size of the
device name.

This caused the actual maximum device name size to be reduced by 1 byte.

Signed-off-by: Théo Battrel <[email protected]>
(cherry picked from commit 972d4c7)
Signed-off-by: alperen sener <[email protected]>
Add `bt_testlib_att_exchange_mtu` function to simplify the procedure.

Signed-off-by: Théo Battrel <[email protected]>
(cherry picked from commit e3cf59b)
Signed-off-by: alperen sener <[email protected]>
The goal of this test is to ensure that setting the device name by
writing to the GAP 'Device Name' characteristic work as expected.

Signed-off-by: Théo Battrel <[email protected]>
(cherry picked from commit 1612220)
Signed-off-by: alperen sener <[email protected]>
…ation

This adds the configuration used when running PTS tests with hci_ipc to
the testcase.yaml, so they are built on integration by CI, avoiding
regression.

Signed-off-by: Ludvig Jordet <[email protected]>
(cherry picked from commit ce4bab5)
Signed-off-by: alperen sener <[email protected]>
…support

Commit adds PSA key support for device key candidate.

Signed-off-by: Ludvig Jordet <[email protected]>
(cherry picked from commit 5facb50)
Signed-off-by: alperen sener <[email protected]>
Commit removes deprecated filed in cdb subnetwork.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit a09fa5f)
Signed-off-by: alperen sener <[email protected]>
…tibility

Commit adds description of key representation incompatibility
for mesh images built with different crypto libraries.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit 5e235bb)
Signed-off-by: alperen sener <[email protected]>
Added warning to the BT_RECV_WORKQ_SYS description
to explain the dangers by using this option.

Signed-off-by: Ingar Kulbrandstad <[email protected]>
(cherry picked from commit 0330ff1)
Signed-off-by: alperen sener <[email protected]>
Add check that the command buffer claimed in `bt_le_create_conn_cancel`
is not `NULL`. Fixes a fault caused by providing the `NULL` buffer to
`bt_hci_cmd_state_set_init`.

Signed-off-by: Jordan Yates <[email protected]>
(cherry picked from commit 7365bcf)
Signed-off-by: alperen sener <[email protected]>
psa_crypto_init was bounded to CONFIG_BT_HOST_CRYPTO_PRNG and
used to be called under prng_init. Updating the ifdef condition
and appropriating the function name for crypto init.

Also it is better to make sure psa_crypto_init called by host.

Signed-off-by: alperen sener <[email protected]>
(cherry picked from commit 22de0b3)
Signed-off-by: alperen sener <[email protected]>
…'t result in 0

Ensure that ~(link.rx.seg) & SEG_NVAL doesn't result in 0.

Fixes #84804
Coverity-CID: 393090

Signed-off-by: Pavel Vasilyev <[email protected]>
(cherry picked from commit fcf09dd)
Signed-off-by: alperen sener <[email protected]>
…ntial overflow

Explicitly cast `BT_MESH_TRANSMIT` output to avoid potential overflow.

Fixes #84759
Fixes #84749
Fixes #84702
Coverity-CID: 487624
Coverity-CID: 487648
Coverity-CID: 487722

Signed-off-by: Pavel Vasilyev <[email protected]>
(cherry picked from commit f82c0e8)
Signed-off-by: alperen sener <[email protected]>
…enough

This commit checks that ATT MTU value returned by `bt_gatt_get_mtu` is
greater or equal to 3 to prevent integer overflow.

Fixes #84693
Coverity-CID: 487743

Signed-off-by: Pavel Vasilyev <[email protected]>
(cherry picked from commit 038173a)
Signed-off-by: alperen sener <[email protected]>
…on issue

Explicitly cast Kconfig option value to avoid truncation issue reported
by Coverity.

Fixes #84697
Coverity-CID: 487737

Signed-off-by: Pavel Vasilyev <[email protected]>
(cherry picked from commit b7f16f1)
Signed-off-by: alperen sener <[email protected]>
…eanless

The first why introduce ADV_FLAG_PROXY_START
see here(zephyrproject-rtos/zephyr#58826)

The main core change is to mark ADV_FLAG_PROXY as moving to the last
enabled proxy instead of before.

But introducing the ADV_FLAG_PROXY_START flag seems meaningless.

Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit bcac572)
Signed-off-by: alperen sener <[email protected]>
Remove START_PENDING flag, and replace with
bt_mesh_adv_is_empty_by_tag

not only make adv_ext.c more readable, but also enhancement

In previous implementation, after proxy started, will check
this flag, and when the flag is true, will direct stop proxy
and re-enter schedule, but has one problem, this flag set true,
but buf will be empty, such as when sending mesh relay messages
will for-each every sets, until find not-active, but also set
previous set START_PENDING flags, so will cause proxy advertising
started->stop->started.

Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit 2ebdcfa)
Signed-off-by: alperen sener <[email protected]>
…advertiser

Add some configuration for test adv_ext.c

Signed-off-by: Lingao Meng <[email protected]>

Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit f5bd217)
Signed-off-by: alperen sener <[email protected]>
Commit removes the double cdb node entry storing
into the settings if device was reprovisioned over
nppi interface.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit 4bb5957)
Signed-off-by: alperen sener <[email protected]>
Adds a macro returning a string representation of a Bluetooth address.
This allows you to print multiple addresses in a single printk or
LOG... call.

Signed-off-by: Håvard Reierstad <[email protected]>
(cherry picked from commit 997814c)
Signed-off-by: alperen sener <[email protected]>
Adds two macros to the babblekit library:
* DEFINE_FLAG_STATIC
* TEST_ASSERT_NO_MSG

Signed-off-by: Håvard Reierstad <[email protected]>
(cherry picked from commit c2c4f2e)
Signed-off-by: alperen sener <[email protected]>
Commit does the following changes:
* Use functionality from the `babbelkit` library for common functions
  related to flags, test progression (failing, passing etc.) and
  synchronization between two devices. Locally defined equivalents are
  removed.
* Removes the files containing only functionality that is provided
  by the `babblekit` library.
* Remove the `test_pre_init_f` and `test_tick_f` functions (commonly
  implemented as `test_init` and `test_tick`) from the modified tests.
  These functions are not needed as they were only used to fail the test
  if a device didn't complete the test within a certain time frame. This
  is already handled by the `sim_length` argument used in the test
  scripts.

Signed-off-by: Håvard Reierstad <[email protected]>
(cherry picked from commit 7737483)
Signed-off-by: alperen sener <[email protected]>
Increase CONFIG_BT_BUF_CMD_TX_COUNT to avoid deadlock when running out
of buffers. See #77241 for the reference.

This fixes Mesh Provisioning Service tests (MESH/NODE/MPS).

Signed-off-by: Pavel Vasilyev <[email protected]>
(cherry picked from commit 6c35d37)
Signed-off-by: alperen sener <[email protected]>
…ze kconfig

Different test layers need different stack sizes for BTP CMD thread
and also AutoPTS might need to overwrite this config based on test
case.

Increase the stack size for mesh tests.

Signed-off-by: alperen sener <[email protected]>
(cherry picked from commit 3cab4fe)
Signed-off-by: alperen sener <[email protected]>
Remove the experimental flag from BT_MESH_USES_TFM_PSA.

Signed-off-by: Ingar Kulbrandstad <[email protected]>
(cherry picked from commit 45f233b)
Signed-off-by: alperen sener <[email protected]>
xfer_progress_complete should be checked instead of end callback

Signed-off-by: alperen sener <[email protected]>
(cherry picked from commit 3fdb81c)
Signed-off-by: alperen sener <[email protected]>
…targets.

Mesh currently works with trusted storage on real targets. Until secure
storage is supported by default disable it.

Signed-off-by: alperen sener <[email protected]>
The SDC HCI controller is defined as a device tree node.
A node representing the SDC controller is added and selected as the
default over the open source link layer. This is consistent with other
SoCs.

Signed-off-by: Rafał Kuźnia <[email protected]>
Reverts the change made in d4d53010f00cadbb4f89c6d41391937646fc1740
(The changes was moved to another file in a restructuring)

The commit incorrectly assumed that no blocking would be allowed in
the syswq. This has caused issues observed among others
in #77241 and #80167

Signed-off-by: Håvard Reierstad <[email protected]>
(cherry picked from commit e13e893)
Signed-off-by: Håvard Reierstad <[email protected]>
…tem WQ

This updates the help text for the Kconfig option BT_MESH_WORKQ_SYS to
take into account the change made in PR #84282 which causes the host to
no longer return -ENOBUFS. Since the mesh will now instead block the
work queue, a note has been added about a potential consequence of this.

Upstream PR #: 86022

Signed-off-by: Ludvig Jordet <[email protected]>
jfischer-no and others added 18 commits March 12, 2025 16:18
The drivers still use the USBREG HAL driver which enables/disables the
interrupt by itself.

Signed-off-by: Johann Fischer <[email protected]>
(cherry picked from commit a05fd62)
…4L20 FLPR core"

This reverts commit 0cc20f2.

Signed-off-by: Michał Stasiak <[email protected]>
… 3.11.0

New nrfx version integrates MDK 8.70.0.

Upstream PR #: 86703

Signed-off-by: Nikodem Kastelik <[email protected]>
…r XO start anomaly"

This reverts commit 2cb2cf2.

Upstream PR #: 86703

Signed-off-by: Nikodem Kastelik <[email protected]>
…to new scheme

MDK 8.70.0 introduced following changes in the device naming:
- renamed nRF54L20 Eng A to nRF54LM20A Eng A
- renamed nRF54L09 Eng A to nRF54LV10A Eng A
Actual SoC renaming will happen in followup PR.

Upstream PR #: 86703

Signed-off-by: Nikodem Kastelik <[email protected]>
Some of the CLOCK events are associated with features
not available on every nRF device.

Upstream PR #: 86703

Signed-off-by: Nikodem Kastelik <[email protected]>
…ness

Setting frame size and endianess is now supported in UARTE HAL,
so these settings must have default values configured
to avoid compiler warnings about uninitialized fields.

Upstream PR #: 86703

Signed-off-by: Nikodem Kastelik <[email protected]>
…x 3.11

To be reverted or overwritten once full renamig of
nRF54L09 and nRF54L20 comes into NCS.

Signed-off-by: Michał Stasiak <[email protected]>
Some time ago a new shim for nRF UARTE was added (uart_nrfx_uarte2.c)
which used nrfx_uarte.c driver underneath. It was supposed to support
nrf54x platforms. However, later on legacy driver (uart_nrfx_uarte.c)
was extended to support nrf54x platforms and it takes less code size,
has better performance and more features. Shim uart_nrfx_uarte2 will
no longer be supported. As new shim is the default and there is a
Kconfig to pick the legacy shim (CONFIG_UART_NRFX_UARTE_LEGACY_SHIM=y)
it cannot be deprecated in the normal way. Additional Kconfig option
is created (DEPRECATED_UART_NRFX_UARTE_LEGACY_SHIM) which is enabled
if CONFIG_UART_NRFX_UARTE_LEGACY_SHIM=n and it selects DEPRECATED.
A warning was also added to the CMakeLists.txt.

Patch removes use CONFIG_UART_NRFX_UARTE_LEGACY_SHIM in tests.

Signed-off-by: Krzysztof Chruściński <[email protected]>
(cherry picked from commit 70118c0)
…figurable

The HCI IPC endpoint bound timeout value was hardcoded and set
to 1000 ms. This value may be differ between platforms, for
exampel due to extended boot time.
The default value used was a bit short for multicore SoCs
that usually may wait for some other service reposnes for
similar time. That may lead to timeout error while other
end of an endpoint was slightly late. Change the default
duration to 2000 ms to give more room for possible delays.

Signed-off-by: Piotr Pryga <[email protected]>
(cherry picked from commit ceb4298)
Signed-off-by: Piotr Pryga <[email protected]>
…of .bss and .data

In some configurations, code is copied from non-volatile memory
to RAM before a core (using that code) is booted.
When that core is reset by expired watchdog, variables shall be
restored to "initial" values.

This is problematic because the core is aware of copy in RAM.
It may not know address in non-volatile memory, where "original"
code is stored.

Add tests which verifiest that .bss and .data sections are
correct when core boots from reset caused by expired watchdog.

Signed-off-by: Sebastian Głąb <[email protected]>
(cherry picked from commit 81df84a)
…uency(nrf54l09pdk)

 Test test_one_tick_timer_train was failing due not being able to
 execute enough 1 tick timeouts. Decrease system ticks frequency
 to make the test pass.

Signed-off-by: Krzysztof Chruściński <[email protected]>
(cherry picked from commit 5e2b998)
Fix checking of shiphold active level.

Signed-off-by: Audun Korneliussen <[email protected]>
(cherry picked from commit db4d24d)
Extend mfd_npm2100_hibernate function with pass_through argument,
which is used to differentiate between hibernate and hibernate_pt
modes.

Signed-off-by: Audun Korneliussen <[email protected]>
(cherry picked from commit 7fd3472)
Align formatting of defines at the top of the mfd_npm2100.c file

Signed-off-by: Sergei Ovchinnikov <[email protected]>
(cherry picked from commit 5aeae41)
Do not reconfigure the SHPHLD button behavior by writing to the sticky
register in drivers: mfd, regulator: npm2100. This is removed to avoid
unexpected behaviors during or after the ship or hibernation modes.

Signed-off-by: Sergei Ovchinnikov <[email protected]>
(cherry picked from commit 1d8ef88)
Added queue for memory slab addresses to ensure that they
are released in correct order. Improved formula for frequency
scaling for nRF54H20. Fixed alternative channel mapping.

Signed-off-by: Michał Stasiak <[email protected]>

Signed-off-by: Sebastian Głąb <[email protected]>
(cherry picked from commit 8260e1f)
olivier-le-sage and others added 4 commits March 13, 2025 12:25
Improves readability by removing the need to check the table
to figure out how many antennas devices A and B are using.

Signed-off-by: Olivier Lesage <[email protected]>
(cherry picked from commit 6f33793)
… standalone test

posix.common contains testsuites that can be separated into smaller
groups of tests. This change moves mqueue into a singular
testsuite at tests/posix/message_passing app directory.

Signed-off-by: Marvin Ouma <[email protected]>
(cherry picked from commit 6b3750f)
…atforms

Previously, intel_ish platforms would fail to link due to
missing `arch_mem_map()` and `arch_mem_unmap()` symbols due
to nuances in the x86 architecture on those platforms.

A separate commit has made MMU a non-user-configurable option,
which removes the ambiguity in POSIX.

Signed-off-by: Chris Friedt <[email protected]>
(cherry picked from commit 784f5b5)
When a queue has been unlinked but not removed the name pointer is set to
NULL. The queue is still in the list when adding new queues and the name
pointer is passed to strcmp.

Signed-off-by: Jari Tervonen <[email protected]>
(cherry picked from commit 3b1e60d)
@tervonenja tervonenja marked this pull request as ready for review March 13, 2025 12:44
@tervonenja tervonenja requested a review from carlescufi March 17, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet