net: Changes needed to make AF_PACKET sockets work with PPP L2 #2628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting the upper protocol type in ethernet_send() by checking the protocol type bits, use the ptype that is already set by the caller. This allows new protocol types to be supported and makes the system extensible. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 2f10d7d) Signed-off-by: Robert Lubos <[email protected]>
The work in Ethernet send in commit 2f10d7d ("net: ethernet: Set the ptype by the caller in send") introduced a bug because we could try to do ARP resolving for ARP packets too. This is clearly a wrong thing to do. So before trying to do ARP resolving, make sure the the packet type is IP packet. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit ed582c1) Signed-off-by: Robert Lubos <[email protected]>
rlubos
force-pushed
the
ncs/net/ppp-packet-socket
branch
from
b295ac0 to
11ad60a
Compare
Currently, the L2 PPP won't work with AF_PACKET socket family as it only supports packets from AF_INET/AF_INET6 families. Because of this, it's not possible to use AF_PACKET RAW or DGRAm sockets with PPP interfaces, as the packets they generate have family field set to AF_PACKET. Fix this, by verifying the LL protocol field in the PPP L2 before passing the packet the respective PPP driver. If the AF_PACKET packet is received, and the protocol field is set to IP/IPv6, update the packet family to AF_INET/AF_INET6 accordingly. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 20faa0e)
rlubos
force-pushed
the
ncs/net/ppp-packet-socket
branch
from
11ad60a to
e0d2127
Compare
SeppoTakalo
approved these changes
Mar 20, 2025
Contributor
|
Seem to work OK on nRFf9160DK when tested with SLM <---> Zephyr Cellular sample. |
Contributor
Author
|
Will come with the upmerge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull changes needed to make AF_PACKET sockets work with PPP L2.