Jlink runner fixes #2641
Merged
Jlink runner fixes #2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… runner is used The logic to detect the default JLink location was placed at the top of the script, executing whenever the script was imported. The west extension command framework loads all runners when initializing, and so this logic was being executed even when using another runner. Move the logic to a function that is only executed when the JLink runner is selected, to avoid executing it at all times. Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit 4c12a8c)
…cutable Instead of hardcoding a set of paths and trying to find the JLink executable in them, use the corresponding Windows registry to locate it: `HKEY_CURRENT_USER\\Software\\SEGGER\\J-Link` Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit bb1794b)
carlescufi
force-pushed
the
jlink-runner-fix
branch
from
81f3b33 to
78bf63b
Compare
|
carlescufi
requested review from
bjarki-andreasen,
kylebonnici,
nordic-piks,
nordicjm and
tmon-nordic
tejlmand
approved these changes
Mar 20, 2025
nordicjm
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://nordicsemi.atlassian.net/browse/NCSIDB-1492