Oct 3354 cherry pick fix for set size notification in csip #2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests Instead of using rs=1,2,3 and 4 we make it 10, 20, 30, 40 as the other values could cause some connection issues. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 7d24771)
…tures The function supports reading multiple controller-based values. It is effectively a copy of struct bt_dev_le but in a more application-oriented definition. It was chosen to keep the features as an array rather than a 64-bit value, as the comparison macros work on arrays and that there already exists new bits > 64 in the core spec which is not yet supported by Zephyr. It is being smoke tested in a generic GATT client test, as the individual values may depend on several Kconfig options. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 44c5c1d)
…BAP broadcast sink Workaround by using `-start_offset` to ensure that the ACL established does not overlap the sink being established. The behavior between nrf52_bsim and nrf54l15bsim is different where in the two device are starting to advertising at the same time in nrf54l15bsim where as there is an offset already in nrf52_bsim test. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]> (cherry picked from commit 490da9e)
…te for the BA The broadcast assistant will now validate the content of the received receive states. Some modifications were done to the tests to properly pass these new validations. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit b361c95)
…le adv Most specs require the use of extended advertising, and most tests used legacy advertising. Implement a common function to create and start an extended advertising set to reduce code duplication. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 0e9a3e0)
…e with BAP Add a selection of interval values that are suitable for BAP, which will allow better coexistence between ISO and ACL, for both broadcast and unicast. Some of these are defined by the BAP spec, and some are defined by Zephyr, since they do have a suggested value from BAP. Samples and tests have been updated to use these new values. Peripheral samples have also been updated with CONFIG_BT_GAP_AUTO_UPDATE_CONN_PARAMS so that the connection parameters from the centrals aren't updated to something else shortly after. The shell has also been updated to use the LE Audio (BAP) values if audio is enabled, and the audio.conf file has disabled automatic updating of the connection parameters as the peripheral, as we rarely (if ever) want to do that. Due to the connection interval change, CI hit an issue with test_bass_broadcast_code in test_main_client_sync, where the reading of the long receive state did not finish before we attempted to do another procedure, so the function was updated to have a retry. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 9d4cc4b)
Renamed BT_CSIP_SET_MEMBER_NOTIFIABLE to BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE to be more specific. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 501b95f)
…et size The set size can now be dynamically set and notified. The rank is added as a argument in the case that changing the set size, also affects the device's rank, as ranks in a coordinated set needs to be continuous. The set coordinator implementation has been updated to support receiving the new set size, and providing this information to the upper layers. This commit adds a babblesim test for the new API, as well as a shell command. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit d19abff)
koffes
force-pushed
the
OCT-3354-cherry-pick-fix-for-set-size-notification-in-csip
branch
from
93774c2 to
26116ef
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick for PTS.