Skip to content

Conversation

@nordic-krch
Copy link
Contributor

I've prepared a hacky solution that adds address of the end of relocation region to the beginning of the vpr binary. Vpr launcher decodes this address and copies only that part to RAM. This approach speeds up boot time and does not overwrite noinit section but it's hacky.

I'm not expecting that it will be merged. Its purpose is rather to trigger the discussion.

cvinayak and others added 30 commits February 21, 2025 11:39
Fix connection event busy check when peripheral role is
using minimal time reservation.

Peripheral and Central have a anchor point sync if the
Peripheral has successfully transmitted once to the Central.

Fixes commit cadef5a ("Bluetooth: Controller: Introduce
BT_CTLR_PERIPHERAL_RESERVE_MAX")'.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 745810c)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
… update

Fix incorrect peripheral drift compensation when connection
events are overlapping and a PHY update causes the currently
used PHY to change.

Incorrect preamble to address that is calculated using
updated PHY was used causing supervision timeout.

Fixed by storing the PHY used in the current connection
event and using that for drift compensation calculation.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 13fa3a0)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Workaround HCTO calculation for BabbleSIM due to need of
addition timeout value required to have anchor point sync.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit e8da981)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…sed events value

Fix incorrect elapsed events value when event prepare are
aborted in the pipeline. This can caused premature
supervision timeouts.

Relates to commit 247037b ("Bluetooth: Controller: Fix
incorrect elapsed events value").

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 1c86636)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…lated latency

Fix Connected ISO to use accumulated latency to update the
payload count.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 3bf3308)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…CIG overlaps

Fix incorrect event_count use in CIG events when the next
CIG interval's prepare overlaps with the current CIG event.
Use separate event_count_prepare variable in ULL and copy
the value in LLL event.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit be91cfe)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Coverity was unhappy that
`struct ll_conn_iso_stream *cis = NULL;` was never assigned to
a non-NULL value, which is due to the assignment being
guarded by `#if defined(CONFIG_BT_CTLR_CONN_ISO)`.

Signed-off-by: Emil Gydesen <[email protected]>
(cherry picked from commit a9279ee)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…t parameter

This fixes uninitialized iso_interval parameter in
bt_hci_evt_le_big_complete.

Signed-off-by: Mariusz Skamra <[email protected]>
(cherry picked from commit 6723625)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
… BASE0

We have previously fixed an issue with shifting and
assigning the value without a cast, but coverity
is still complaining about aa[1] and aa[0] with:

"Casting narrower unsigned aa[1] to wider signed type
int effectively tests its lower bound."

Using the common function, sys_get_le24, should fix this issue.

Signed-off-by: Emil Gydesen <[email protected]>
(cherry picked from commit 9fca7ee)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…onal code

Fix BT_CTLR_LOW_LAT_ULL conditional compilation code by
decoupling it from BT_CTLR_LOW_LAT code.

BT_CTLR_LOW_LAT_ULL makes ULL execution context to tailchain
in comparison to continuously process in a while loop.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 5119896)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…Adv Sync

Fix incorrect device address reported in the LE Periodic
Advertising Sync Established event when using Periodic
Advertiser List.

During Extended Scanning there can be an ADV_EXT_IND PDU
received between currently being received ADV_EXT_IND PDU
and AUX_ADV_IND PDU; if the one received between has an
address match then incorrectly the Periodic Synchronization
was established to the device whos AUX_ADV_IND PDU is being
received. Fix by storing the auxiliary context that has the
address match and compare with it when matching the SID in
SyncInfo of AUX_ADV_IND PDU being received prior to creating
the synchronization.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 83e2ec3)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…E BIG Complete

Fix missing sync_delay and transport_latency information in HCI
LE BIG Complete event.

Relates to commit 1a640e4 ("Bluetooth: controller:
Included transport latency in LE_Big_Established").

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 8ebc4f3)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…chain reception

Fix regression introduced in Periodic Advertising
Synchronization due to change related to multiple
Advertising chain reception.

Related commit c334ed5 ("Bluetooth: Controller: Fix
multiple Extended Adv chain reception"), and
commit da792a9 ("Bluetooth: Controller: Fix interleaved
extended scanning assert").

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 2461552)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…dic Sync

Fix assertion due to changes introduced to support multiple
advertising chain reception.

Auxiliary context association with the Periodic Sync context
was not cleared due to which when terminating a Periodic
Synchronization triggered an assertion check, under race
conditions, detecting that the auxiliary context was already
released.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 3263729)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
…ed in node rx

Fix to release aux context stored in node rx, and not in the
superior scan or sync context as the one in the superior scan
or sync context could be reset or have a different new aux
context when multiple advertising chain reception is used.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit a806592)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix regression in scan aux release now that aux context is
retrieved from the node rx when supporting multiple chain
reception.

Relates to commit a806592 ("Bluetooth: Controller: Fix
to release aux context stored in node rx").

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit 49642ef)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
… association

Remove redundant reset of LLL sync aux context association.

Related to commit 3263729 ("Bluetooth: Controller: Fix
assertion terminating Periodic Sync").

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
(cherry picked from commit dcdd330)
Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Change number of IRQ parameter for nRF54L20 devices.

Signed-off-by: Adam Kondraciuk <[email protected]>
(cherry picked from commit 50c21f1)
…g driver

Update with the latest nordic hal

Signed-off-by: Alberto Escolar Piedras <[email protected]>
(cherry picked from commit 2a95e22)
… 3.10.0

New nrfx version contains support for nRF7120 Eng A device.

Signed-off-by: Nikodem Kastelik <[email protected]>
(cherry picked from commit 3fe559a)
…nction

Avoid unhandled event calling assert function

Signed-off-by: Matthias Hauser <[email protected]>
(cherry picked from commit 5438643)
…nts for now

New events from nrfx_clock driver are not utilized for now
by the clock_control, so should be ignored to avoid assertion.

Signed-off-by: Nikodem Kastelik <[email protected]>
(cherry picked from commit 2692f16)
…4H20"

This reverts commit b978fbb.

Signed-off-by: Nikodem Kastelik <[email protected]>
Adding support for reset reasons in the nRF54H20 SoC.

Signed-off-by: Karol Lasończyk <[email protected]>
(cherry picked from commit f551b2d)
…EXTENDED_ENABLED

nrfx_config is setting NRFX_SPIM_EXTENDED_ENABLED based on presence of
a DT property. However, there are test cases when it is expected that
extended SPIM features will be disabled on a target that supports
extended features. Allow that by not setting the value if it is already
defined.

Signed-off-by: Krzysztof Chruściński <[email protected]>
(cherry picked from commit eebaf81)
There is no reason to duplicate `nrfx_config_*.h` files.
Use configuration files from `hal_nordic/nrfx/templates`.

Signed-off-by: Marcin Szymczyk <[email protected]>
(cherry picked from commit aa3f787)
* Move all KConfig configuration from CMake to `nrfx_kconfig.h`
* Move macro utils from `nrfx_kconfig.h` to `nrfx_zephyr_utils.h`
* Move GRTC channels allocation from `nrfx_kconfig.h` to
  `nrfx_reserved_resources.h`

Signed-off-by: Marcin Szymczyk <[email protected]>
(cherry picked from commit 94589b7)
Added ncs-specific modules to nrfx_config_reserved_resources.
The modules are:
- mpsl
- nrfe

Signed-off-by: Rafał Kuźnia <[email protected]>
As nrfx_config is included before MDK, MDK-specific device symbols
cannot be used. Use Kconfig symbols instead.

Signed-off-by: Nikodem Kastelik <[email protected]>
ArekBalysNordic and others added 22 commits March 20, 2025 10:25
…fset

The offset value in the PSA ITS non-volatile space is dedicated to
OpenThread key reference IDs. This offset must not overwrite any
other ranges already in use within the PSA ITS non-volatile space.

Signed-off-by: Arkadiusz Balys <[email protected]>
(cherry picked from commit ba9f627)
The BLE acronym is not an official description of Bluetooth
LE, and the Bluetooth SIG only ever refers to it as Bluetooth
Low Energy or Bluetooth LE, so Zephyr should as well.

This commit does not change any board or vendor specific
documentation, and the term BLE may still be used in those.
It will be up to the vendors to update it if they want,
since many of them are using the term BLE in their
products.

Signed-off-by: Emil Gydesen <[email protected]>
(cherry picked from commit 571f26c)
Update Kconfig options for qualification:
 - Remove experimental on qualified feature.
 - Add experimental on unqualified feature.
 - BT_L2CAP_ECRED is not marked as experimental upstream and we qualify it
   downstream.

Signed-off-by: Joakim Andersson <[email protected]>
Signed-off-by: Trond Einar Snekvik <[email protected]>
Signed-off-by: Martí Bolívar <[email protected]>
Signed-off-by: Robert Lubos <[email protected]>
Signed-off-by: Dominik Ermel <[email protected]>
Signed-off-by: Ingar Kulbrandstad <[email protected]>
Signed-off-by: Torsten Rasmussen <[email protected]>
Signed-off-by: Herman Berget <[email protected]>
Signed-off-by: Tomasz Moń <[email protected]>
Signed-off-by: Théo Battrel <[email protected]>
(cherry picked from commit e92e87d)
…PSA key IDs

We need to make sure that within Zephyr different users of the PSA APIs
don't interfere with each other because of using the same numerical IDs
for persistent assets.

This takes care of the PSA key IDs when using persistent keys through
the PSA Crypto API.
See the comments in `<zephyr/psa/key_ids.h>` for more information.

This removes the recently-introduced Kconfig options that allowed changing
the base IDs subsystems were using for their persistent keys.

Signed-off-by: Tomi Fontanilles <[email protected]>
(cherry picked from commit 0c368e8)
…tions

Commit removes weak attribute and renames some functions
in crypto_psa.c since there is no centralized distribution
of the PSA key ID in bsim tests and no necessity to
reimplement native mesh approach.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit acc752f)
Commit removes api prefix for static functions
in crypto psa.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit e075e08)
Commit removes centralized PSA key ID distribution
in mesh bsim tests since secure storage is
instantiated on every simulated device.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit 6a9802e)
… runner is used

The logic to detect the default JLink location was placed at the top of
the script, executing whenever the script was imported. The west
extension command framework loads all runners when initializing, and so
this logic was being executed even when using another runner.

Move the logic to a function that is only executed when the JLink runner
is selected, to avoid executing it at all times.

Signed-off-by: Carles Cufi <[email protected]>
(cherry picked from commit 4c12a8c)
…cutable

Instead of hardcoding a set of paths and trying to find the JLink
executable in them, use the corresponding Windows registry to locate it:

`HKEY_CURRENT_USER\\Software\\SEGGER\\J-Link`

Signed-off-by: Carles Cufi <[email protected]>
(cherry picked from commit bb1794b)
During raw scan, Need to disable NRF_WIFI_MGMT_BUFF_OFFLOAD.
UMAC will send beacon and probe responses directly to the host,
regardless of the mgmt_buff_offload flag's value.
Host needs to resubmit buffers to LMAC.

Signed-off-by: Kapil Bhatt <[email protected]>
(cherry picked from commit 1179014)
…uffers

For different values of reorder buffer throughputs are consistent,
Setting reorder buffer size to half of the RX buffers configured.

Signed-off-by: Kapil Bhatt <[email protected]>
(cherry picked from commit 9f7307f)
Sidewalk becomes NCS Add-on.
There is no need to trigger Sidewalk tests.

Signed-off-by: Tomasz Tyzenhauz <[email protected]>
Added common overlay for nRF54L20 cores.

Upstream PR #: 87388

Signed-off-by: Michał Stasiak <[email protected]>
…54l15_cpuflpr

Add overlay for nrf54l15dk_nrf54l15_cpuflpr target.

Signed-off-by: Krzysztof Chruściński <[email protected]>
(cherry picked from commit bec4a84)
Add printing reset reason at the beginning of the sample. Makes it easier
to determine if sample correctly wakes up from LP mode.

Signed-off-by: Bartlomiej Buczek <[email protected]>
(cherry picked from commit c08edf7)
Add TDM support for nRF54H20 and nRF54L20

Upstream PR #: 82144

Signed-off-by: Adam Kondraciuk <[email protected]>
Added missing comparator node to nRF54L20 devicetree.

Upstream PR #: 87352

Signed-off-by: Michał Stasiak <[email protected]>
…nel ram region

There are cases when code is relocated and we want to copy code
and part of data (e.g. data section) but avoid copying noinit
section. To achieve that noinit section is placed at the end
of kernel_ram region.

Signed-off-by: Krzysztof Chruściński <[email protected]>
…code

In order to allow extract relocation code size from the binary
add dummy instruction at the beginning which will write address of
the end of the relocation part to the register. It is decoded by the
host core which copies riscv code.

Signed-off-by: Krzysztof Chruściński <[email protected]>
Instead of copying whole partition dedicated for VPR decode end address
from the beginning of the binary code. Only code and certain portion of
data is copied (excluding noinit section). It reduces the boot time and
fixes issue where noinit section is overwritten after reset.

Signed-off-by: Krzysztof Chruściński <[email protected]>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels