-
Notifications
You must be signed in to change notification settings - Fork 719
v3.0 rebase branch #2804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bjarki-andreasen
merged 0 commits into
nrfconnect:v4.0.99-ncs1-branch
from
bjarki-andreasen:v3.0-rebase-branch
Apr 24, 2025
Merged
v3.0 rebase branch #2804
bjarki-andreasen
merged 0 commits into
nrfconnect:v4.0.99-ncs1-branch
from
bjarki-andreasen:v3.0-rebase-branch
Apr 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlubos
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some leftover nrf-squash!/fixup! commits that should be cleaned up.
Also I see quite a few reverts in the rebased history - shouldn't they cancel out with the original commits during the rebase?
e05e74f to
e66365c
Compare
rlubos
approved these changes
Apr 23, 2025
fa87abf to
a0e545c
Compare
rlubos
approved these changes
Apr 23, 2025
anangl
approved these changes
Apr 23, 2025
|
a0e545c
into
nrfconnect:v4.0.99-ncs1-branch
15 of 19 checks passed
3e0ce76 to
a0e545c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


v3.0 rebase branch