Cpuconf #2815
Cpuconf #2815
Conversation
boards/nordic/nrf54h20dk/board.cmake
Outdated
| OR CONFIG_BOARD_NRF54H20DK_NRF54H20_CPUAPP_IRON | ||
| OR CONFIG_BOARD_NRF54H20DK_NRF54H20_CPURAD_IRON) |
There was a problem hiding this comment.
This formatting makes my eyes bleed
There was a problem hiding this comment.
You want one option on each line right?
There was a problem hiding this comment.
OR on end-of-line, perhaps? CONFIG_ on same vertical?
There was a problem hiding this comment.
Yeah one per line would be nice instead of two on one then one on each of the next.
Sorry for the super-unclear comment :D (not sarcastic)
| /* This is not yet an exhaustive memory map, and contain only a minimum required to boot | ||
| * the radio core. |
There was a problem hiding this comment.
Seems a bit off given that this is the radio core, a slight rephrase might be needed.
| ram: 192 # Guessed value | ||
| flash: 256 # Guessed value |
There was a problem hiding this comment.
The RAM is as per spec, and flash corresponds to the memory map we have in the docs, so I would say that the comments here are superfluous
| @@ -0,0 +1,28 @@ | |||
| # Copyright (c) 2024 Nordic Semiconductor ASA | |||
soc/nordic/nrf54h/Kconfig
Outdated
| select HAS_POWEROFF | ||
|
|
||
| config SOC_NRF54H20_CPURAD_ENABLE | ||
| bool "NRF54H20 Radio core is enabled at boot time" |
There was a problem hiding this comment.
nit: "Enable nRF54H20 Radio core at boot time"
There was a problem hiding this comment.
This broke CI.
Some kind of rule about prompts starting with Enable.
soc/nordic/nrf54h/Kconfig
Outdated
| bool "NRF54H20 Radio core is enabled at boot time" | ||
| default y if NRF_802154_SER_HOST | ||
| help | ||
| This option enables releasing the Radio 'force off' signal, which |
soc/nordic/nrf54h/cpurad_mgmt.c
Outdated
|
|
||
| static int nrf54h20_cpurad_init(void) | ||
| { | ||
| uint32_t dummy = 0xbadcafe; |
There was a problem hiding this comment.
Should we comment on why this is here? (missing boot report)
There was a problem hiding this comment.
I think at this point we should move the memory map into one file (I see that zephyrproject-rtos/zephyr#88937 does this)
There was a problem hiding this comment.
discussed offline. will be done at a later time
SebastianBoe
force-pushed
the
cpuconf
branch
4 times, most recently
from
74962e8 to
e332a2d
Compare
…rd variant The required jlink script was not added due to missing entry in the board check. Also change the check for app vs rad to be on SOC level. Signed-off-by: Håkon Amundsen <[email protected]> (cherry picked from commit 4edc003)
This is needed for next generation Secure Domain firmware. Upstream PR #: 88908 Signed-off-by: Sebastian Bøe <[email protected]>
Encode the radiocore's address into the application's DT as the application needs to instruct IRONside SE about where the radiocore should be booted from. Upstream PR #: 89009 Signed-off-by: Sebastian Bøe <[email protected]>
Port SYS_INIT to use soc_early_init_hook as SYS_INITs are legacy. Upstream PR #: 88908 Signed-off-by: Sebastian Bøe <[email protected]>
…nit_hook Boot the radiocore from the app in soc_late_init_hook. Upstream PR #: 88908 Signed-off-by: Sebastian Bøe <[email protected]>
…/cpuapp/iron Add support for nrf54h20dk/nrf54h20/cpuapp/iron to the samples/sysbuild/hello_world sample. Upstream PR #: 88908 Signed-off-by: Sebastian Bøe <[email protected]>
|
|
creating a new PR due to the desire to have a bot manage the manifest PR |
4 participants
cpuconf