[Backport v3.7.99-ncs3-branch] pm: Fixes in policy events #2851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pm_policy_event_register() API takes absolute cycles as the second arg, like pm_policy_event_update(), but the arg is renamed time_us and treated as a relative time in us rather than abs cycles. Fix implementation of pm_policy_event_register() to treat cycles like pm_policy_event_update() and API docs suggest. Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 145d041)
The default policy currently directly references the private variable next_event from policy_events.c to then convert the cycle of said event (if exists) to a kernel tick in the future, something policy_events.c already implements and exposes through pm_policy_next_event_ticks(). Additionally, the implementation of pm_policy_next_state() in policy_default.c already gets the nearest kernel tick, wherein the next event has already been accounted for in, see implementation of pm_system_suspend(). This commit removes the redundant and layer violating computation if the tick of the next event from policy_default.c and updates the test test_pm_policy_events to not use default policy to determine if pm_policy_next_event_ticks() is correct. Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 14117b4)
Update events to use uptime ticks, which is a monotonic clock which in the same res as kernel ticks. This makes comparisons simple and removes the complexity of dealing with wrapping counter values. The wrapping is particularly problematic for events since this makes it quite complex to track if an event has occured in the past, or will occur in the future. This info is needed to know if an event has actually been handled or not. Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 59779eb)
|
bjarki-andreasen
approved these changes
May 13, 2025
kl-cruz
approved these changes
May 20, 2025
adamkondraciuk
approved these changes
May 20, 2025
nika-nordic
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks from Zephyr upstream to use 64 bit uptime ticks for PM events.