[nrf noup] Added nrf54h20dk/nrf54h20/cpuapp/iron/mcuboot/b0 #2852
Conversation
There was a problem hiding this comment.
Pull Request Overview
A PR to add a new board configuration for the nRF54H20-DK with mcuboot support, providing an appropriate memory map for use with mcuboot and NSIB.
- Introduces a new YAML file with board specifications for the mcuboot variant.
- Updates the board.yml file to include mcuboot as a sub-variant for the iron configuration.
Reviewed Changes
Copilot reviewed 2 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| boards/nordic/nrf54h20dk/nrf54h20dk_nrf54H20_cpuapp_iron_mcuboot_b0_0_9_0.yaml | Adds board configuration details, including memory map and supported peripherals. |
| boards/nordic/nrf54h20dk/board.yml | Updates the board variants to include a mcuboot variant with sub-variant b0. |
Files not reviewed (7)
- boards/nordic/nrf54h20dk/Kconfig.defconfig: Language not supported
- boards/nordic/nrf54h20dk/Kconfig.nrf54h20dk: Language not supported
- boards/nordic/nrf54h20dk/Kconfig.sysbuild: Language not supported
- boards/nordic/nrf54h20dk/board.cmake: Language not supported
- boards/nordic/nrf54h20dk/nrf54h20dk_nrf54h20-memory_map_iron_mcuboot_b0.dtsi: Language not supported
- boards/nordic/nrf54h20dk/nrf54h20dk_nrf54h20_cpuapp_iron_mcuboot_b0.dts: Language not supported
- boards/nordic/nrf54h20dk/nrf54h20dk_nrf54h20_cpuapp_iron_mcuboot_b0_defconfig: Language not supported
Comments suppressed due to low confidence (3)
boards/nordic/nrf54h20dk/board.yml:14
- Ensure that the indentation for the new 'variants' block adheres to the YAML structure used elsewhere in the file to avoid potential parsing issues.
variants:
boards/nordic/nrf54h20dk/nrf54h20dk_nrf54H20_cpuapp_iron_mcuboot_b0_0_9_0.yaml:13
- Verify that the 'ram' value is specified according to project standards (e.g., in kilobytes) and consider adding a comment for clarity if the unit is not self-evident.
ram: 256
boards/nordic/nrf54h20dk/nrf54h20dk_nrf54H20_cpuapp_iron_mcuboot_b0_0_9_0.yaml:14
- Verify that the 'flash' value matches the intended memory map for this board variant and consider clarifying the unit of measurement if needed.
flash: 480
ahasztag
force-pushed
the
NCSDK-33104_b0_lillium_poc
branch
from
7a5be82 to
3aa4295
Compare
| select SOC_NRF54H20_CPUAPP if (BOARD_NRF54H20DK_NRF54H20_CPUAPP || \ | ||
| BOARD_NRF54H20DK_NRF54H20_CPUAPP_IRON) | ||
| BOARD_NRF54H20DK_NRF54H20_CPUAPP_IRON || \ | ||
| BOARD_NRF54H20DK_NRF54H20_CPUAPP_IRON_MCUBOOT_B0) |
There was a problem hiding this comment.
indent here is off, and below
|
Though note that it would probably be better to have this in sdk-nrf as a board extension rather than in sdk-zephyr as a noup which is likely to have merge conflicts in future upmerges - see https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html#board-extensions for details |
You are absolutely right, I did not know of a possibility of such board extension. |
ahasztag
requested review from
a team,
adsz-nordic,
nordic-mik7,
robertstypa and
tomchy
ahasztag
force-pushed
the
NCSDK-33104_b0_lillium_poc
branch
2 times, most recently
from
b315fef to
5b73f54
Compare
boards/nordic/nrf54h20dk/nrf54h20dk_nrf54h20_cpuapp_iron_mcuboot_b0_0_9_0.yaml
Outdated
Show resolved
Hide resolved
ahasztag
force-pushed
the
NCSDK-33104_b0_lillium_poc
branch
2 times, most recently
from
4933006 to
b0b57cd
Compare
| boot_partition: &cpuapp_boot_partition { | ||
| label = "mcuboot"; | ||
| }; | ||
|
|
||
| boot_partition_slot1: &cpuapp_boot_slot1_partition { | ||
| label = "mcuboot-image-1"; | ||
| }; |
There was a problem hiding this comment.
as per sdk-nrf PR, needs proper names
There was a problem hiding this comment.
No longer applicable, moved board definition to sdk-nrf
ahasztag
force-pushed
the
NCSDK-33104_b0_lillium_poc
branch
2 times, most recently
from
c416c64 to
1c5fd03
Compare
ahasztag
force-pushed
the
NCSDK-33104_b0_lillium_poc
branch
2 times, most recently
from
1f296d2 to
6fe1057
Compare
Added nrf54h20dk/nrf54h20/cpuapp/iron/mcuboot/b0 in the supported boards list for the subsys/mgmt/mcumgr/smp_svr sample in the serial variant. Signed-off-by: Artur Hadasz <[email protected]>
ahasztag
force-pushed
the
NCSDK-33104_b0_lillium_poc
branch
from
6fe1057 to
37126bd
Compare
|
| - rd_rw612_bga | ||
| - nrf52840dk/nrf52840 | ||
| - nrf54h20dk/nrf54h20/cpuapp/iron | ||
| - nrf54h20dk/nrf54h20/cpuapp/iron/mcuboot/b0 |
There was a problem hiding this comment.
move this to sdk-nrf as we do for other tests/samples - see https://github.com/nrfconnect/sdk-nrf/tree/main/samples/zephyr and https://github.com/nrfconnect/sdk-nrf/tree/main/tests/zephyr for examples
|
Not needed anymore, everything has been moved to NCS |
3 participants
This is one of the solutions for adding an appropriate memory map in case mcuboot and NSIB are to be used.
Note: the nrf54h20dk/nrf54h20/cpuapp/iron/mcuboot/b0 board was added in zephyr. This might not be the final approach. Other ways of specifying the memory map might be used.