Skip to content

Conversation

MarkusLassila
Copy link
Contributor

Add Asynchronous UART implementation, which does not drop data
when automatic hardware-flow-control is set in the device tree.

With automatic hardware flow control, the CTS pin will be
automatically deactivated when there are no more asynchronous
UART RX buffers available. After buffer space becomes available,
and UART RX is restarted, the CTS pin will be activated.

bjarki-andreasen and others added 3 commits May 14, 2025 14:58
Update the board overlays to support hardware flow control for
testing.

Signed-off-by: Bjarki Arge Andreasen <[email protected]>
(cherry picked from commit 525d3d6)
Extend test modem uart backend test suite to support testing hw
flow control, which is performed by using a small receive
buffer for the modem uart backend, and slowing down the read
of received data, ensuring the buffer will be overrun if hw flow
control is not working.

Signed-off-by: Bjarki Arge Andreasen <[email protected]>
(cherry picked from commit 24dd379)
Add Asynchronous UART implementation, which does not drop data
when automatic hardware-flow-control is set in the device tree.

With automatic hardware flow control, the CTS pin will be
automatically deactivated when there are no more asynchronous
UART RX buffers available. After buffer space becomes available,
and UART RX is restarted, the CTS pin will be activated.

Signed-off-by: Markus Lassila <[email protected]>
(cherry picked from commit 10bd2de)
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@MarkusLassila
Copy link
Contributor Author

@bjarki-andreasen: SonarCloud Code Analysis fails on code duplication. Can this be merged despite that or does the upstream need to be reworked?

@bjarki-andreasen
Copy link
Contributor

bjarki-andreasen commented May 14, 2025

@bjarki-andreasen: SonarCloud Code Analysis fails on code duplication. Can this be merged despite that or does the upstream need to be reworked?

Upstream shall not be reworked :) code duplication is expected here, I will force merge it after approvals if sonarcloud indeed blocks it

@MarkusLassila
Copy link
Contributor Author

@bjarki-andreasen: SonarCloud Code Analysis fails on code duplication. Can this be merged despite that or does the upstream need to be reworked?

Upstream shall not be reworked :) code duplication is expected here, I will force merge it after approvals if sonarcloud indeed blocks it

That is what I was expecting, but given that we are running sonarcloud in here, and it seems to block, I was questioning my sanity. :)

@bjarki-andreasen bjarki-andreasen merged commit 8425a1a into nrfconnect:main May 14, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants