Skip to content

Conversation

rlubos
Copy link
Contributor

@rlubos rlubos commented May 14, 2025

Regular history cleanup.

Comment on lines 11 to 28
runs-on: ubuntu-22.04
name: Run commit tags checks on patch series (PR)
steps:
- name: Update PATH for west
run: |
echo "$HOME/.local/bin" >> $GITHUB_PATH

- name: Checkout the code
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0

- name: Run the commit tags
uses: nrfconnect/action-commit-tags@main
with:
target: .
upstream: zephyrproject-rtos/zephyr/main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
fetch-depth: 0

- name: Run the commit tags
uses: nrfconnect/action-commit-tags@main

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow

Unpinned 3rd party Action 'Commit tags' step [Uses Step](1) uses 'nrfconnect/action-commit-tags' with ref 'main', not a pinned commit hash
Comment on lines 11 to 17
runs-on: ubuntu-latest
steps:
- name: handle manifest PR
uses: nrfconnect/action-manifest-pr@main
with:
token: ${{ secrets.NCS_GITHUB_TOKEN }}
manifest-pr-title-details: ${{ github.event.pull_request.title }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{}}
runs-on: ubuntu-latest
steps:
- name: handle manifest PR
uses: nrfconnect/action-manifest-pr@main

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow

Unpinned 3rd party Action 'handle manifest PR' step [Uses Step](1) uses 'nrfconnect/action-manifest-pr' with ref 'main', not a pinned commit hash
Copy link

github-actions bot commented May 14, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nordic zephyrproject-rtos/hal_nordic@119ff5b zephyrproject-rtos/hal_nordic@a5a2277 (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@rlubos rlubos merged commit 36ffd80 into nrfconnect:main May 15, 2025
2 checks passed
@rlubos rlubos deleted the rebase-05-2025 branch May 15, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants