[nrf fromlist] dfu: Fix MCUBOOT_UPDATE_FOOTER_SIZE warning #2919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning was the result of the MCUBOOT_UPDATE_FOOTER_SIZE Kconfig option being under "if IMG_MANAGER", but at the same time being unconditionally set in by CMake mcuboot. At the same there is no way for CMake to find out if CONFIG_IMG_MANAGER is set before setting the value of CONFIG_MCUBOOT_UPDATE_FOOTER_SIZE (as the value of CONFIG_IMG_MANAGER is uknown before finishing Kconfig parsing). Upstream PR #: 90721 Signed-off-by: Artur Hadasz <[email protected]>
ahasztag
force-pushed
the
NCSDK-29615_fix_mcuboot_build_warnings
branch
from
001f630 to
04f2a74
Compare
The warning was the result of the MCUBOOT_UPDATE_FOOTER_SIZE Kconfig option being under "if IMG_MANAGER", but at the same time being unconditionally set in by CMake mcuboot. At the same there is no way for CMake to find out if CONFIG_IMG_MANAGER is set before setting the value of CONFIG_MCUBOOT_UPDATE_FOOTER_SIZE (as the value of CONFIG_IMG_MANAGER is uknown before finishing Kconfig parsing). Upstream PR #: 90721 Signed-off-by: Artur Hadasz <[email protected]>
ahasztag
force-pushed
the
NCSDK-29615_fix_mcuboot_build_warnings
branch
from
04f2a74 to
7d75836
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning was the result of the MCUBOOT_UPDATE_FOOTER_SIZE Kconfig option being under "if IMG_MANAGER", but at the same time being unconditionally set in by CMake mcuboot.
At the same there is no way for CMake to find out if CONFIG_IMG_MANAGER is set before setting the value of CONFIG_MCUBOOT_UPDATE_FOOTER_SIZE (as the value of CONFIG_IMG_MANAGER is uknown before finishing
Kconfig parsing).
Upstream PR #: 90721