[nrf noup] bluetooth: host: cs: Fix bt_le_cs_start_test param_len update #2972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppryga-nordic
force-pushed
the
fix-cs-start-test-buf-hdr-update-ncs
branch
from
5d6edb7 to
aa66fcf
Compare
ppryga-nordic
changed the title
|
Fixed |
ppryga-nordic
requested review from
alwa-nordic,
olivier-le-sage and
rugeGerritsen
rugeGerritsen
approved these changes
Jun 23, 2025
olivier-le-sage
approved these changes
Jun 23, 2025
ppryga-nordic
force-pushed
the
fix-cs-start-test-buf-hdr-update-ncs
branch
from
aa66fcf to
933297c
Compare
There was a change in HCI fuffers encoding: #88710. First byte in the HCI buf->data[0] is HCI type. The header starts from buf->data[1]. Current implementation was overwriting the opcode field in the buffer when updating the hdr->param_len. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
force-pushed
the
fix-cs-start-test-buf-hdr-update-ncs
branch
from
933297c to
486141d
Compare
|
|
CI on manifest PR in sdk-nrf is green. The PR is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change in HCI fuffers encoding: #88710. First byte in the HCI buf->data[0] is HCI type.
The header starts from buf->data[1].
Current implementation was overwriting the opcode field in the buffer when updating the hdr->param_len.