[nrf fromtree] net: sockets_offload: Fix build error with NO_OPTIMIZA…#2973
Merged
rlubos merged 1 commit intonrfconnect:mainfrom Jun 24, 2025
Merged
Conversation
…TIONS When CONFIG_NO_OPTIMIZATIONS the compiler will not inline socket_offload_dns_is_enabled(), which means calls to socket_offload* remain, and the linker will fail with in function `zsock_getaddrinfo': undefined reference to `socket_offload_getaddrinfo' in function `zsock_freeaddrinfo': undefined reference to `socket_offload_freeaddrinfo' Instead of relaying on that function being inlined and the if'ed code being removed, let's just use the preprocessor. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no> (cherry picked from commit dc24583) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
|
jukkar
approved these changes
Jun 23, 2025
katgiadla
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick fix for native_sim builds with optimizations disabled.