Skip to content

Conversation

@rlubos
Copy link
Contributor

@rlubos rlubos commented Jun 26, 2025

There was an API breaking change in net_mgmt upstream, cherry-pick the change to align NCS codebase and catch any potential breakages early.

@rlubos rlubos changed the title net: Cherry pick net_mgmt APIchanges net: Cherry pick net_mgmt API changes Jun 26, 2025
@rlubos rlubos force-pushed the ncs/cherry-pick-net-mgmt-api-changes branch 2 times, most recently from bf5df2a to 7cd7c29 Compare July 1, 2025 08:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2025

@rlubos rlubos force-pushed the ncs/cherry-pick-net-mgmt-api-changes branch from 7cd7c29 to cfaa41b Compare July 28, 2025 14:07
@rlubos rlubos requested a review from krish2718 July 28, 2025 14:24
rlubos and others added 9 commits August 5, 2025 09:54
Instead of using 32 bit enum values for event numbers, convert
the code to use 64 bit long bit fields. This means that the
user API is changed to use 64 bit event values instead of 32
bit event values.

Signed-off-by: Jukka Rissanen <[email protected]>
(cherry picked from commit 5a9a39c)
Signed-off-by: Robert Lubos <[email protected]>
…t_mgmt sockets

We cannot use the network management event number directly as
a socket option value because the management value is uint64_t
and that cannot be mapped directly to 32 bit integer.
So have an intermediate socket option that is mapped to actual
network management request number in getsockopt() and setsockopt().

Signed-off-by: Jukka Rissanen <[email protected]>
(cherry picked from commit 2ed2232)
Signed-off-by: Robert Lubos <[email protected]>
…I changes

Add information how the net_mgmt request handler is changed.
The event number type is changed from uint32_t to uint64_t to allow
the event command to be a bit mask instead of enum value.

Signed-off-by: Jukka Rissanen <[email protected]>
(cherry picked from commit 6b0597f)
Signed-off-by: Robert Lubos <[email protected]>
As per API overview documentation, a braking API change must
increment major version number.

https://docs.zephyrproject.org/latest/develop/api/overview.html#api-overview

Signed-off-by: Jukka Rissanen <[email protected]>
(cherry picked from commit b1a8655)
Signed-off-by: Robert Lubos <[email protected]>
This has been missed in net_mgmt rework in commit
5a9a39c.

Signed-off-by: Robert Lubos <[email protected]>
(cherry picked from commit 3e70425)
net_event.h header makes use of macros defined in net_mgmt.h, therefore
it should include that header.

Signed-off-by: Robert Lubos <[email protected]>
(cherry picked from commit ae7d7a8)
Support to configure BSS max idle period at runtime.

Signed-off-by: Ajay Parida <[email protected]>
(cherry picked from commit c70b350)
Signed-off-by: Robert Lubos <[email protected]>
@rlubos rlubos force-pushed the ncs/cherry-pick-net-mgmt-api-changes branch from cfaa41b to e48a563 Compare August 5, 2025 07:55
30s is too aggressive for most APs, and hostapd also uses 5mins as the
default value.

Signed-off-by: Chaitanya Tata <[email protected]>
(cherry picked from commit 59ff126)
Signed-off-by: Robert Lubos <[email protected]>
@rlubos rlubos force-pushed the ncs/cherry-pick-net-mgmt-api-changes branch from e48a563 to 172a278 Compare August 5, 2025 08:07
@rlubos rlubos merged commit 8277731 into nrfconnect:main Aug 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants