[nrf noup] boards: nordic: nrf54lm20 adjust ROM_START_OFFSET #3046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapi-no
approved these changes
Jul 14, 2025
michalek-no
requested review from
de-nordic,
fundakol,
gchwier,
nordicjm and
nvlsianpu
nordicjm
reviewed
Jul 14, 2025
Comment on lines
6
to
+7
| config ROM_START_OFFSET | ||
| default 0 if PARTITION_MANAGER_ENABLED |
There was a problem hiding this comment.
this should already be the case https://github.com/nrfconnect/sdk-nrf/blob/main/Kconfig.nrf#L35
There was a problem hiding this comment.
This has no effect in our case.
There was a problem hiding this comment.
For some reasons, the override is not applied in various projects (e.g. nRF Desktop).
nordicjm
approved these changes
Jul 14, 2025
adds kconfig that was probably skipped during migration. Signed-off-by: Mateusz Michalek <[email protected]>
michalek-no
force-pushed
the
mb-lm20-offset
branch
from
8cc18ff to
c7dfa7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds kconfig that was probably skipped during migration.