[nrf noup] hal_nordic: Fix MPSL include that might cause unwanted dependencies #3092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-rk
approved these changes
Jul 28, 2025
AyturkDuzen
approved these changes
Jul 28, 2025
nordicjm
requested changes
Jul 29, 2025
| #endif /* CONFIG_NRF_802154_RADIO_DRIVER */ | ||
|
|
||
| #if defined(CONFIG_MPSL) | ||
| #include <mpsl.h> |
There was a problem hiding this comment.
add nrf-squash! with original commit title in commit message
There was a problem hiding this comment.
Added nrf-squash! [nrf noup] modules: hal_nordic: adjust nrfx reservations to NCS to commit message
…endencies nrf-squash! [nrf noup] modules: hal_nordic: adjust nrfx reservations to NCS The #include <mpsl.h> in reserved resources header introduced MPSL types and other MPSL headers to be available in nrf hal build. That might cause problems when using MPSL headers in subsystems for example clock driver. The MPSL reserved resources are provided in mpsl_hwres.h header file that is enough to be included in hal_nordic. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
force-pushed
the
fix-mpsl-resources-allocation-include
branch
from
1482a53 to
bf068a2
Compare
nordicjm
approved these changes
Jul 29, 2025
AyturkDuzen
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #include <mpsl.h> in reserved resources header introduced MPSL types and other MPSL headers to be available in nrf hal build. That might cause problems when using MPSL headers in subsystems for example clock driver.
The MPSL reserved resources are provided in mpsl_hwres.h header file that is enough to be included in hal_nordic.