[nrf noup] samples: bluetooth: mesh: update stack sizes #3131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akredalen
force-pushed
the
mesh_sample_stack_update
branch
from
6657125 to
ccdca76
Compare
omkar3141
reviewed
Aug 4, 2025
Comment on lines
2
to
6
| CONFIG_MAIN_STACK_SIZE=4392 | ||
| CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=4740 | ||
| CONFIG_BT_MESH_SETTINGS_WORKQ_STACK_SIZE=1664 | ||
| CONFIG_BT_MESH_ADV_STACK_SIZE=3960 | ||
| CONFIG_BT_RX_STACK_SIZE=3288 |
There was a problem hiding this comment.
Suggested change
| CONFIG_MAIN_STACK_SIZE=4392 | |
| CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=4740 | |
| CONFIG_BT_MESH_SETTINGS_WORKQ_STACK_SIZE=1664 | |
| CONFIG_BT_MESH_ADV_STACK_SIZE=3960 | |
| CONFIG_BT_RX_STACK_SIZE=3288 | |
| CONFIG_MAIN_STACK_SIZE=4400 | |
| CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=4800 | |
| CONFIG_BT_MESH_SETTINGS_WORKQ_STACK_SIZE=1700 | |
| CONFIG_BT_MESH_ADV_STACK_SIZE=4000 | |
| CONFIG_BT_RX_STACK_SIZE=3300 |
I just rounded it up to next hundred. If not, we will definitely get questions on how did we calculate exact number, as those numbers to veryy specific down to unit place.
Now, we can say, we experiemented, added some 10% (or something, I don't know how much margin did you add), and rounded it up to next hundred.
What do you think? Does anyone else has any other opinion?
There was a problem hiding this comment.
@omkar3141 Sorry, I forgot to mention - the values are set with 50% margin, based off the thread analysis. With a lot for testing it seems that such margin was needed due to spikes in usage during provisioning. Rounding up is fine with me.
Increased stack sizes for mesh provisoner sample. Values are based of thread analysis, plus added margin. Signed-off-by: Stine Åkredalen <[email protected]>
akredalen
force-pushed
the
mesh_sample_stack_update
branch
from
ccdca76 to
3594a32
Compare
omkar3141
approved these changes
Aug 4, 2025
alxelax
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased stack sizes for mesh provisoner sample. Values are based on thread analysis, plus added margin.