[nrf fromlist] net: zperf: Improve UDP multicast upload #3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapbh
requested review from
jukkar,
krish2718,
rado17,
rlubos and
sachinthegreen
rlubos
approved these changes
Aug 18, 2025
sachinthegreen
approved these changes
Aug 18, 2025
UDP multicast uploads did not produce zperf-compatible server stats, so the client waited for and tried to decode a non-existent reply, causing “Unexpected response flags” and misleading “LAST PACKET NOT RECEIVED!!!” output. This change treats multicast as client-only: after sending the negative-id FIN it does not wait for or decode server stats, Instead transmits the FIN a few times to help receivers detect test end. The shell prints a clear “Statistics (client only)” summary for multicast and suppresses the error when client stats are valid. Unicast behavior is unchanged. Upstream PR #: 94344 Signed-off-by: Kapil Bhatt <[email protected]>
krish2718
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDP multicast uploads did not produce zperf-compatible server stats, so the client waited for and tried to decode a non-existent reply, causing “Unexpected response flags” and misleading “LAST PACKET NOT RECEIVED!!!” output.
This change treats multicast as client-only: after sending the negative-id FIN it does not wait for or decode server stats, Instead transmits the FIN a few times to help receivers detect test end. The shell prints a clear “Statistics (client only)” summary for multicast and suppresses the error when client stats are valid.
Unicast behavior is unchanged.
Upstream PR #: 94344