-
Notifications
You must be signed in to change notification settings - Fork 717
drivers: adc: nrfx: synchronize upstream changes #3211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anangl
approved these changes
Aug 19, 2025
masz-nordic
approved these changes
Aug 19, 2025
nordic-piks
approved these changes
Aug 20, 2025
nordic-segl
approved these changes
Aug 20, 2025
0769170
to
937bd14
Compare
nordic-segl
approved these changes
Aug 20, 2025
anangl
requested changes
Aug 20, 2025
…n single-mode" This reverts commit e54b994. Signed-off-by: Jakub Zymelka <[email protected]>
… single-ended ADC readings" This reverts commit 84ab620. Signed-off-by: Jakub Zymelka <[email protected]>
…C internal sampling timer" This reverts commit 77547f8. Signed-off-by: Jakub Zymelka <[email protected]>
…al sampling timer The SAMPLERATE register can be used as a local timer instead of triggering individual SAMPLE tasks. When SAMPLERATE.MODE is set to Timers, it is sufficient to trigger SAMPLE task only once in order to start the SAADC and triggering the STOP task will stop sampling. The SAMPLERATE.CC field controls the sample rate. The SAMPLERATE timer should not be combined with SCAN mode and only one channel should be enabled when using the internal timer. (cherry picked from commit 376b34c) Signed-off-by: Jakub Zymelka <[email protected]>
…ended ADC readings The ADC driver API already supports ADC readings which can return signed values, these are differential readings. In Nordic's datasheet, we have a mode called "single ended", but its just a name. "Single ended" is a differential reading, with the negative channel tied to GND. This is not compatible with zephyrs definition of a single ended reading. To support Nordic's "single ended" mode, the user must configure a differential reading, with the negative input tied to ground, which the saadc driver can then use to configure the reading as Nordic SAADC "single ended", and return negative values as expected. (cherry picked from commit 138f977) Signed-off-by: Jakub Zymelka <[email protected]>
…rection Increment pointer only when channel was selected. Upstream PR #: 94705 Signed-off-by: Jakub Zymelka <[email protected]>
937bd14
to
52c34d0
Compare
anangl
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback of obsolete commits and replacing them with correct ones already merged in upstream.