[nrf fromtree] bluetooth: host: gatt: destroy key after hash calc com… #3218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyraLengfeld
approved these changes
Aug 22, 2025
alxelax
approved these changes
Aug 22, 2025
…pletes To generate the GATT Database Hash characteristic, the function `db_hash_setup` is called. It allocates an entry for the AES key that will be used in the CMAC calculation. Next, `db_hash_update` is called to feed all GATT database entries into the hash. Finally, `db_hash_finish` produces the resulting hash. However, the AES key entry allocated in `db_hash_setup` was not being destroyed after the hash generation completed. This caused a memory leak, eventually leading to the error `PSA_ERROR_INSUFFICIENT_MEMORY` (`-134`). This commit fixes the issue by destroying the allocated AES key after the GATT Database Hash calculation is complete, by calling `psa_destroy_key` in `db_hash_finish`. Signed-off-by: Pavel Vasilyev <[email protected]> (cherry picked from commit bcdd74d)
PavelVPV
force-pushed
the
cherry_pick_gatt_db_hash_calc_fix
branch
from
52bff16 to
45eef23
Compare
|
Rebased to see if it fixes build issues in matter sample in sdk-nrf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pletes
To generate the GATT Database Hash characteristic, the function
db_hash_setupis called. It allocates an entry for the AES key that will be used in the CMAC calculation. Next,db_hash_updateis called to feed all GATT database entries into the hash. Finally,db_hash_finishproduces the resulting hash.However, the AES key entry allocated in
db_hash_setupwas not being destroyed after the hash generation completed. This caused a memory leak, eventually leading to the errorPSA_ERROR_INSUFFICIENT_MEMORY(-134).This commit fixes the issue by destroying the allocated AES key after the GATT Database Hash calculation is complete, by calling
psa_destroy_keyindb_hash_finish.(cherry picked from commit bcdd74d)