[nrf fromlist] soc: nordic: nrf54h: Implement idle with cache retaine… #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkondraciuk
requested review from
kl-cruz,
nordic-krch,
nika-nordic,
masz-nordic,
mstasiaknordic and
mib1-nordic
nordic-piks
reviewed
Sep 5, 2025
soc/nordic/nrf54h/power.c
Outdated
| case 0: | ||
| /* Substate for idle with cache powered on - not implemented yet. */ | ||
| break; | ||
| case 1: /* Substate for idle with cache retained - not implemented yet. */ |
There was a problem hiding this comment.
nit: this comment /* Substate for idle with cache retained - not implemented yet. */ can be changed - your are implementing it now :)
adamkondraciuk
force-pushed
the
NRFX-8180-idle-with-cache-retained
branch
from
8731bba to
39e4fd1
Compare
kl-cruz
force-pushed
the
NRFX-8180-idle-with-cache-retained
branch
from
39e4fd1 to
c37e50e
Compare
kl-cruz
approved these changes
Sep 16, 2025
nika-nordic
approved these changes
Sep 16, 2025
|
Could You please rebase this PR? CI is failing... |
adamkondraciuk
force-pushed
the
NRFX-8180-idle-with-cache-retained
branch
2 times, most recently
from
6e33c76 to
7a24992
Compare
|
Commit tags check fails because:
|
adamkondraciuk
force-pushed
the
NRFX-8180-idle-with-cache-retained
branch
4 times, most recently
from
a95bc05 to
aa34a3a
Compare
adamkondraciuk
force-pushed
the
NRFX-8180-idle-with-cache-retained
branch
from
158be95 to
ae840f8
Compare
This reverts commit a41a631. Signed-off-by: Adam Kondraciuk <[email protected]>
This reverts commit cdc11bd. Signed-off-by: Adam Kondraciuk <[email protected]>
…d state Add new idle state with cache retention enabled. Signed-off-by: Adam Kondraciuk <[email protected]> (cherry picked from commit 6f7a183)
Add the definition of pm_s2ram_stack memory region for nRF54H20. Upstream PR #: 95914 Signed-off-by: Tomasz Chyrowicz <[email protected]> (cherry picked from commit c274834)
Added support for hardening decision on resume from S2RAM by MCUboot bootloader. Application sets additional variable to MCUBOOT_S2RAM_RESUME_MAGIC which allows the bootloader to doublecheck. Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit d4bb1c6)
MCUBOOT requires LTO to be enabled, while using code relocation forces switching it off. When `__ramfunc` is used, LTO can also be used. Then the `cache_retain_and_sleep` function will execute properly, but a bit slower. Upstream PR #: Signed-off-by: Adam Kondraciuk <[email protected]>
adamkondraciuk
force-pushed
the
NRFX-8180-idle-with-cache-retained
branch
from
ae840f8 to
6ae2bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d state
Add new idle state with cache retention enabled.
Upstream PR #: 95474