[nrf fromlist] samples: cleanup sysbuild/hello_world sample #3264
+60
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-piks
approved these changes
Sep 10, 2025
This reverts commit 470fcc9. Signed-off-by: Torsten Rasmussen <[email protected]>
Remove the prompt for REMOTE_BOARD. REMOTE_BOARD should not be having a prompt or be configurable on command line. Instead REMOTE_BOARD should be defined based on the SoC as this will allow creation of new boards using the same SoC, and thereby be able to build the sample out-of-the-box for any supported SoC. This allows us to remove several single line config files. For SoCs with more than two CPU clusters, such as the nRF54h20, then a choice is provided to select specific core. Remove the REMOTE_BOARD restriction, as this sample will build and run even for single core SoCs, and may be useful for testing other sysbuild multi-image features even for single cores SoCs. Upstream PR #: 95745 Signed-off-by: Torsten Rasmussen <[email protected]>
Pass on the board revision to remote image build if specified for the application image board target. Upstream PR #: 95745 Signed-off-by: Torsten Rasmussen <[email protected]>
PM support is still required for nRF53/nRF54l15 in the context of NCS. Signed-off-by: Gerard Marull-Paretas <[email protected]> Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
sysbuild_hello_world_cleanup
branch
from
329d8cd to
ba5b69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the prompt for REMOTE_BOARD.
REMOTE_BOARD should not be having a prompt or be configurable on command
line.
Instead REMOTE_BOARD should be defined based on the SoC as this will
allow creation of new boards using the same SoC, and thereby be able
to build the sample out-of-the-box for any supported SoC.
This allows us to remove several single line config files.
For SoCs with more than two CPU clusters, such as the nRF54h20, then a
choice is provided to select specific core.
Remove the REMOTE_BOARD restriction, as this sample will build and run
even for single core SoCs, and may be useful for testing other sysbuild
multi-image features even for single cores SoCs.
Upstream PR #: 95745