-
Notifications
You must be signed in to change notification settings - Fork 733
[nrf fromtree] arch/arm/cortex_m: support for bridge to the next image S2RAM resume routines #3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
077fd10 to
95cbf6b
Compare
1 task
tomchy
approved these changes
Sep 24, 2025
95cbf6b to
0a97155
Compare
0a97155 to
d5582ec
Compare
carlescufi
requested changes
Sep 29, 2025
Contributor
carlescufi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjarki-andreasen would you be able to propose a solution that can actually work for both up and downstream?
d5582ec to
162c9a3
Compare
44c6ac8 to
84bf948
Compare
e69b330 to
7a11b57
Compare
bjarki-andreasen
approved these changes
Oct 7, 2025
7a11b57 to
2a907a9
Compare
2a907a9 to
eff7d2e
Compare
This reverts commit cc5a1b4. Signed-off-by: Andrzej Puzdrowski <[email protected]>
Introduce hook for customize reset.S code even before stack is initialized or RAM is accessed. Hook can be enabled using CONFIG_SOC_EARLY_RESET_HOOK=y. Hook implementation is by soc_early_reset_hook() function which should be provided by custom code. Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit 418eed0)
eff7d2e to
daf2e15
Compare
carlescufi
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For case when the zephyr-rtos application is the bootloader and booted target application had suspended the device, the resume operation would be initiated by the bootloader which could redirect execution to the application S2RAM routines directly.
Thanks to that target application would resume using compiled in S2RAM routines. Such scheme allows the zephyr-rtos based bootloader to not mock the application while does S2RAM resume operation. Therefore no need for keeping compatibility with S2RAM resume mechanism in application. No need to enable PM nor PM_S2RAM anymore in the bootloader.
Advantages:
Cons:
* low-level patch in start-up ARM coderef.: NCSDK-35391
zephyr-rtos: zephyrproject-rtos/zephyr#96290zephyr-rtos: zephyrproject-rtos/zephyr#96962
Turned to [nrf noup] Patch can't be accepted upstream.reworked to the hook branch in reset.S of cortex_m startup code
also this nrf fromlist commit is reverted as now it's code can be moved to the hook implementation
manifest-pr-skip