net: Cherry-pick TCP and mDNS regressions bugfixes #3300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inal data Add a test case for a scenario where the final data sent by one peer is acknowledged in the FIN,ACK response from the other peer. Verify that the acknowledgment is handled correctly, and a consecutive sequence number sent by the TCP stack in such case is set correctly. This complements the other existing test for FIN packet handling, which verified that data received in a FIN packet is handled correctly. With those tests in place it should be safer to update any logic related to FIN packet handling. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 99b4357)
In case FIN packed also acknowledged most recently sent data, not all ack-related TCP context variables were updated, resulting in invalid SEQ number values sent in consecutive packets. Fix this by refactoring the FIN handling in TCP_ESTABLISHED state. Instead of having a separate block strictly for FIN packet processing, let the packet be processed by common code responsible for regular data/ack processing. This should be less error-prone for any future modifications or not-yet-discovered issues. Only after the common processing of data/ack is done, we check whether FIN flag was present in the packet, and mark the connection for closing. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 1781505)
dns_unpack_query() no longer prepends the unpacked query with extra dot, therefore mDNS responder needs to be aligned with this change when parsing result and preparing response. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 9e59229)
…ange dns_unpack_query() no longer prepends the unpacked query with extra dot, therefore LLMNR responder needs to be aligned with this change when parsing result and preparing response. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit fda8247)
…_query() change Not sure why didn't this cause the test to fail, but just for completeness, align this test suite with dns_unpack_query() change as well. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit c885844)
carlescufi
approved these changes
Sep 24, 2025
jukkar
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just brought those regressions with the upmerge, so get the fixes ASAP.