[nrf fromlist] drivers: watchdog: wdt_nrfx: use standard instantiation #3329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstasiaknordic
force-pushed
the
nrfx_wdt_rework
branch
2 times, most recently
from
3299bd6 to
f466a51
Compare
mstasiaknordic
force-pushed
the
nrfx_wdt_rework
branch
2 times, most recently
from
401bf3c to
07f2bb8
Compare
mstasiaknordic
force-pushed
the
nrfx_wdt_rework
branch
from
07f2bb8 to
18f6d4a
Compare
magp-nordic
approved these changes
Oct 28, 2025
Comment on lines
+140
to
+141
| if (err_code == -ENOMEM) { | ||
| return err_code; |
Contributor
There was a problem hiding this comment.
Doing it like in wdt_nrf_disable would make more sense, and will work if more error codes are added to nrfx_wdt_channel_alloc, but can be left as is.
magp-nordic
force-pushed
the
nrfx_wdt_rework
branch
from
18f6d4a to
8903250
Compare
Used API for standard instantiation and replaced nrfx_err_t error values with errno. Upstream PR #: 96776 Signed-off-by: Michał Stasiak <[email protected]>
…load Replaced magic number with defined symbol for maximum reload value in milliseconds Upstream PR #: 96776 Signed-off-by: Michał Stasiak <[email protected]>
Removed Kconfig symbols for each WDT instance which are no longer needed. Upstream PR #: 96776 Signed-off-by: Michał Stasiak <[email protected]>
Removed unnecessary symbol. Upstream PR #: 96776 Signed-off-by: Michał Stasiak <[email protected]>
magp-nordic
force-pushed
the
nrfx_wdt_rework
branch
from
8903250 to
c2c56db
Compare
masz-nordic
approved these changes
Oct 30, 2025
masz-nordic
merged commit b9bf21a
into
nrfconnect:collab-nrfx-4.0
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used API for standard instantiation and replaced nrfx_err_t error values with errno.
Removed Kconfig symbols for each WDT instance which are no longer needed.