[nrf fromlist] drivers: spi: spi_nrfx_spi(m/s): use standard instantiation #3332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstasiaknordic
force-pushed
the
nrfx_spim_rework
branch
from
c883e11 to
9d6f7cb
Compare
mstasiaknordic
force-pushed
the
nrfx_spim_rework
branch
3 times, most recently
from
f759a85 to
c579627
Compare
magp-nordic
reviewed
Oct 15, 2025
Contributor
magp-nordic
left a comment
magp-nordic
left a comment
There was a problem hiding this comment.
@mstasiaknordic why is this a draft? Is it not ready for review yet? Only PRs in upstream were supposed to be drafts, as they will not be merged yet, but PRs in NCS can be regular ones.
Contributor
Author
I will get it out of draft once I confirm it works in all cases, probably when CI is more green |
Used API for standard instantiation and replaced nrfx_err_t error values with errno. Upstream PR #: 96792 Signed-off-by: Michał Stasiak <[email protected]>
mstasiaknordic
force-pushed
the
nrfx_spim_rework
branch
from
c579627 to
967f34d
Compare
Contributor
Author
|
CI seems to be green now, apart from unrelated fails. Ready for review :) |
bjarki-andreasen
approved these changes
Oct 17, 2025
Contributor
bjarki-andreasen
left a comment
bjarki-andreasen
left a comment
There was a problem hiding this comment.
Looks pretty much perfect
kl-cruz
approved these changes
Oct 17, 2025
magp-nordic
reviewed
Oct 17, 2025
mstasiaknordic
changed the title
Removed Kconfig symbols for each SPIM instance which are no longer needed. Upstream PR #: 96792 Signed-off-by: Michał Stasiak <[email protected]>
Changed error codes, driver instantiation and removed unnecessary symbols. Upstream PR #: 96792 Signed-off-by: Michał Stasiak <[email protected]>
Addded macro responsible for translating new errno error codes to strings. Upstream PR #: 96792 Signed-off-by: Michał Stasiak <[email protected]>
Used API for standard instantiation and replaced nrfx_err_t error values with errno. Upstream PR #: 96792 Signed-off-by: Michał Stasiak <[email protected]>
Removed Kconfig symbols for each SPIS instance which are no longer needed. Upstream PR #: 96792 Signed-off-by: Michał Stasiak <[email protected]>
mstasiaknordic
force-pushed
the
nrfx_spim_rework
branch
from
967f34d to
6fe33d5
Compare
magp-nordic
approved these changes
Oct 20, 2025
masz-nordic
merged commit 12fab80
into
nrfconnect:collab-nrfx-4.0
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used API for standard instantiation and replaced nrfx_err_t error values with errno.
Removed Kconfig symbols for each SPIM and SPIS instance which are no longer needed.