[nrf noup] boards: nordic: Enable PSA RNG for nrf54h20 #3346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ironside PSA is currently not available upstream, just to clarify for others reading the PR description. |
SebastianBoe
approved these changes
Oct 1, 2025
Contributor
SebastianBoe
left a comment
SebastianBoe
left a comment
There was a problem hiding this comment.
I'm not sure what entropy-prng is.
But having PSA provide entropy by default on 54H makes sense to me as it is the most secure source of entropy.
Users that want faster, less secure, entropy can explicitly develop/configure this at a later time I suppose.
Vge0rge
force-pushed
the
54h20_psa_rng_ironside
branch
2 times, most recently
from
3ce7175 to
3282d05
Compare
tomi-font
reviewed
Oct 3, 2025
subsys/secure_storage/Kconfig
Outdated
| menuconfig SECURE_STORAGE | ||
| bool "Secure storage subsystem" | ||
| depends on !BUILD_WITH_TFM | ||
| depends on !NRF_IRONSIDE |
Contributor
There was a problem hiding this comment.
missing # in Upstream PR #
SebastianBoe
reviewed
Oct 6, 2025
Vge0rge
force-pushed
the
54h20_psa_rng_ironside
branch
8 times, most recently
from
4bbc19d to
87487a4
Compare
Vge0rge
force-pushed
the
54h20_psa_rng_ironside
branch
2 times, most recently
from
fb66123 to
7846926
Compare
Contributor
|
can we remove CONFIG_FAKE_ENTROPY_NRF_PRNG and all associated to it now? |
Contributor
Author
I am not sure about this, what I can tell is that with this PR the option FAKE_ENTROPY_NRF_PRNG cannot be enabled without modifying the device tree nodes. I am not sure if there are use cases that still require it for some reason. |
Vge0rge
force-pushed
the
54h20_psa_rng_ironside
branch
from
7846926 to
17ca6ec
Compare
degjorva
approved these changes
Oct 20, 2025
tomi-font
approved these changes
Oct 21, 2025
Vge0rge
force-pushed
the
54h20_psa_rng_ironside
branch
from
17ca6ec to
eb6308b
Compare
Noup since Ironside not available upstream and it is required for PSA RNG. This enables the PSA RNG as the default Zephyr entropy provider for the nrf54h20dk cpuapp and cpurad targets. Signed-off-by: Georgios Vasilakis <[email protected]>
Exclude the application and radio core targets for nRF54H20 since they use Ironside as their PSA storage provider. Upstream PR #: 96915 Signed-off-by: Georgios Vasilakis <[email protected]>
…PTO_PSA The dependency should be PSA_CRYPTO_CLIENT and not MBEDTLS_PSA_CRYPTO_CLIENT because the former is more generic. TF-M can indeed provide PSA Crypto API, not only Mbed TLS. Signed-off-by: Valerio Setti <[email protected]> (cherry picked from commit 46614de)
…_PSA_CRYPTO_C The driver code only relies on legacy Mbed TLS crypto, not on PSA API, so enabling MBEDTLS_PSA_CRYPTO_C is not needed here. Signed-off-by: Valerio Setti <[email protected]> (cherry picked from commit 76037ce)
…_C in BT_SILABS_EFR32 The driver only uses psa_generate_random() so ENTROPY_C is not required. Signed-off-by: Valerio Setti <[email protected]> (cherry picked from commit 7b7b4fc)
…YPTO The goal of new Kconfig PSA_CRYPTO_PROVIDER is to automatically enable any of the PSA Crypto API provider available for the platform without having the user to manually pick the proper one. This provider can be either TF-M, if that's enabled in the build, or Mbed TLS otherwise. PSA_CRYPTO_PROVIDER simplifies also modules/subsystem Kconfigs removing blocks as: select MBEDTLS if !BUILD_WITH_TFM select MBEDTLS_PSA_CRYPTO_C if !BUILD_WITH_TFM Kconfig PSA_CRYPTO_PROVIDER_CUSTOM is also added to allow the end user to add a custom implementation of PSA Crypto API instead of TF-M or Mbed TLS ones. Signed-off-by: Valerio Setti <[email protected]> (cherry picked from commit 1bc2db5)
Vge0rge
force-pushed
the
54h20_psa_rng_ironside
branch
from
eb6308b to
51a6baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noup since Ironside not available upstream and it is required for PSA RNG.
This enables the PSA RNG as the default Zephyr entropy provider for the nrf54h20dk cpuapp and cpurad targets.