Alignment to nrfx_timer rework #3349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mib1-nordic
force-pushed
the
nrfx_timer_rework
branch
2 times, most recently
from
6604469 to
6803053
Compare
mib1-nordic
force-pushed
the
nrfx_timer_rework
branch
3 times, most recently
from
b3cb979 to
6d1e718
Compare
magp-nordic
approved these changes
Oct 28, 2025
jaz1-nordic
force-pushed
the
nrfx_timer_rework
branch
3 times, most recently
from
14c6ff4 to
6e1cec5
Compare
Allow the samples to work both at Full-Speed and High-Speed exposing the same capabilities at both speeds. Signed-off-by: Tomasz Moń <[email protected]> (cherry picked from commit ff50dfb)
…onversion glitch Rework the formula used to convert timer CC values to SOF offset to eliminate a "division glitch" happening around SOF crossing, i.e. when the framestart shifts from being captured shortly before SOF to being captured shortly after SOF. When audio samples are consumed faster than nominal, i.e. when there is +1 samples every now and then, the reported SOF offset at High-Speed was going 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, "glitch" 7, 6, 5, 4, 3, 2, 1, 0, -1, -2, ... With the fix the SOF offset goes as expected from 0 to -1, i.e. there is no jump from 0 to 7 around the SOF crossing and the reported SOF offset goes linearly (until it is correclty bumped from negative values back to positive values when +1 sample packet is transmitted on I2S). Signed-off-by: Tomasz Moń <[email protected]> (cherry picked from commit 6bb4cb5)
…call Pinctrl call is redundant as uarte_periph_enable calls it as well. Signed-off-by: Krzysztof Chruściński <[email protected]> (cherry picked from commit 7a6c7ea)
Remove TIMER config symbols to align to changes in nrfx driver. Upstream PR #: 96858 Signed-off-by: Michał Bainczyk <[email protected]>
Remove TIMER config symbols to align to changes in nrfx driver. Upstream PR #: 96858 Signed-off-by: Michał Bainczyk <[email protected]>
Align feedback_nrf to changes in nrfx TIMER driver. Upstream PR #: 96858 Signed-off-by: Michał Bainczyk <[email protected]>
…nrfx Align driver to changes in nrfx UARTE driver. Upstream PR #: 96858 Signed-off-by: Michał Bainczyk <[email protected]>
jaz1-nordic
force-pushed
the
nrfx_timer_rework
branch
from
6e1cec5 to
b3be871
Compare
masz-nordic
approved these changes
Oct 30, 2025
masz-nordic
merged commit c30df96
into
nrfconnect:collab-nrfx-4.0
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.