-
Notifications
You must be signed in to change notification settings - Fork 734
[nrf noup] scripts: ci: check_compliance: Check Kconfigs for enable #3362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why is this a no-up? Not using "Enable" should be in the style guide allowing us to upstream this commit |
It's problematic because zephyr modules do not follow this because they are external projects not zephyr-specific projects, so upon enabling it in zephyr it fails because of 3 modules and it's unlikely that they will be fixed in their upstream repos, so this has to be enabled here like this so it actually runs in sdk-nrf due to how sdk-nrf works (it is added as a zephyr module) |
I know I'm not maintaining this part, but I anyways want to help out with some suggestions on how to address this:
|
a83004e to
4870a86
Compare
bb8a352 to
c2b1252
Compare
1f9041c to
52ba3c4
Compare
52ba3c4 to
0bb5e68
Compare
Allows checking sdk-nrf for Kconfig prompts that start with "Enable" as these should not be allowed Signed-off-by: Jamie McCrae <[email protected]>
nrf-squash! [nrf noup] scripts: ci: check_compliance: Exclude some docs Excludes bare metal release docs from the invalid Kconfig check as these will have old Kconfigs that have been removed Signed-off-by: Jamie McCrae <[email protected]>
0bb5e68 to
42276d8
Compare
Allows checking sdk-nrf for Kconfig prompts that start with "Enable" as these should not be allowed