Skip to content

[nrf fromlist] drivers: uart_nrfx_uarte: Fix runtime device PM for interrupt driven API #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anangl merged 1 commit into from
Nov 25, 2025
Merged

[nrf fromlist] drivers: uart_nrfx_uarte: Fix runtime device PM for interrupt driven API #3527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions drivers/serial/uart_nrfx_uarte.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2832,27 +2832,35 @@ static void uarte_nrfx_irq_tx_enable(const struct device *dev)
{
NRF_UARTE_Type *uarte = get_uarte_instance(dev);
struct uarte_nrfx_data *data = dev->data;
bool already_enabled;

if (IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME)) {
pm_device_runtime_get(dev);
}
pm_device_runtime_get(dev);

unsigned int key = irq_lock();

data->int_driven->disable_tx_irq = false;
data->int_driven->tx_irq_enabled = true;
nrf_uarte_int_enable(uarte, NRF_UARTE_INT_TXSTOPPED_MASK);
already_enabled = data->int_driven->tx_irq_enabled;
if (!already_enabled) {
data->int_driven->disable_tx_irq = false;
data->int_driven->tx_irq_enabled = true;
nrf_uarte_int_enable(uarte, NRF_UARTE_INT_TXSTOPPED_MASK);
}

irq_unlock(key);

if (already_enabled) {
pm_device_runtime_put(dev);
}
}

/** Interrupt driven transfer disabling function */
static void uarte_nrfx_irq_tx_disable(const struct device *dev)
{
struct uarte_nrfx_data *data = dev->data;
/* TX IRQ will be disabled after current transmission is finished */
data->int_driven->disable_tx_irq = true;
data->int_driven->tx_irq_enabled = false;
if (data->int_driven->tx_irq_enabled) {
/* TX IRQ will be disabled after current transmission is finished */
data->int_driven->disable_tx_irq = true;
data->int_driven->tx_irq_enabled = false;
}
}

/** Interrupt driven transfer ready function */
Expand Down Expand Up @@ -2888,15 +2896,23 @@ static void uarte_nrfx_irq_rx_enable(const struct device *dev)
{
NRF_UARTE_Type *uarte = get_uarte_instance(dev);

nrf_uarte_int_enable(uarte, NRF_UARTE_INT_ENDRX_MASK);
if (!nrf_uarte_int_enable_check(uarte, NRF_UARTE_INT_ENDRX_MASK)) {
pm_device_runtime_get(dev);

nrf_uarte_int_enable(uarte, NRF_UARTE_INT_ENDRX_MASK);
}
}

/** Interrupt driven receiver disabling function */
static void uarte_nrfx_irq_rx_disable(const struct device *dev)
{
NRF_UARTE_Type *uarte = get_uarte_instance(dev);

nrf_uarte_int_disable(uarte, NRF_UARTE_INT_ENDRX_MASK);
if (nrf_uarte_int_enable_check(uarte, NRF_UARTE_INT_ENDRX_MASK)) {
pm_device_runtime_put_async(dev, K_NO_WAIT);

nrf_uarte_int_disable(uarte, NRF_UARTE_INT_ENDRX_MASK);
}
}

/** Interrupt driven error enabling function */
Expand Down