Cherry pick runner changes for 3.2.0 #3536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlescufi
force-pushed
the
cherry-pick-runner-changes
branch
from
9deba2b to
a2943e2
Compare
carlescufi
force-pushed
the
cherry-pick-runner-changes
branch
from
a2943e2 to
132749a
Compare
Move the argparse.add_argument() call to the abstract base class and augment the RunnerCaps class with a dry_run parameter. Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit 48e0481)
In order to avoid duplication of logic in runners, allow subclasses of ZephyrBinaryRunner to set self.dry_run so that they can then reuse the logic in core.py to log instead of execute. Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit ffe2028)
…ed json Until now the code was using the path to the .hex file to select the directory where the generated JSON file required for nrfutil would be generated. But this has a problem: if the .hex file in a sysbuild project is located in the tree as a precompiled binary, the runner would place a file in there and make the tree dirty. Instead use the build_dir folder which always corresponds (in both sysbuild and regular builds) to the current target build directory. Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit d6f5aa9)
carlescufi
force-pushed
the
cherry-pick-runner-changes
branch
from
132749a to
d10fdab
Compare
rlubos
approved these changes
Nov 25, 2025
anangl
approved these changes
Nov 25, 2025
carlescufi
pushed a commit
to NordicBuilder/sdk-nrf
that referenced
this pull request
Nov 26, 2025
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3536 Signed-off-by: Nordic Builder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.