Skip to content

[nrf noup] modules: trusted-firmware-m: Add KConfig for KEY_WRAPPING_MODULE#3774

Closed
AntonZma wants to merge 1 commit intonrfconnect:mainfrom
AntonZma:aes-kw-tfm-support
Closed

[nrf noup] modules: trusted-firmware-m: Add KConfig for KEY_WRAPPING_MODULE#3774
AntonZma wants to merge 1 commit intonrfconnect:mainfrom
AntonZma:aes-kw-tfm-support

Conversation

@AntonZma
Copy link

This PR adds KConfig option for the TFM_CRYPTO_KEY_WRAPPING_MODULE_ENABLED to enable support for AES key wrap APIs.

@AntonZma AntonZma requested review from Vge0rge and frkv February 12, 2026 14:37
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Feb 12, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-zephyr#3774

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Feb 12, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-zephyr#3774

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a noup patch ?

We have our own glue layer in sdk-nrf, https://github.com/nrfconnect/sdk-nrf/tree/main/modules/trusted-firmware-m, and one reason that is to avoid noup up patches.

…MODULE

This commit adds KConfig option for the TFM_CRYPTO_KEY_WRAPPING_MODULE_ENABLED
to enable support for AES key wrap APIs.

This commit is noup since:
1. key wrapping is not yet supported by upstream
TF-M (key wrapping was introduced by PSA API v1.4);
2. key wrapping functionality added on top of PAKE support
for TF-M, which is also noup.

Ref: NCSDK-29189
Ref: NCSDK-28740

Signed-off-by: Anton Zyma <anton.zyma@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Feb 20, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-zephyr#3774

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not following the discussion but I don't understand the need for this given that there is a modules directory in sdk-nrf, and it's used for exactly that purpose as other modules do, e.g sdk-mcuboot does it, see Kconfig and CMake files in https://github.com/nrfconnect/sdk-nrf/tree/main/modules the MCUboot ones are in https://github.com/nrfconnect/sdk-nrf/tree/main/modules/mcuboot and this is even further expanded in sdk-nrf-bm here: https://github.com/nrfconnect/sdk-nrf-bm/tree/main/modules which actually has the BM sdk-mcuboot module file used which uses the sdk-nrf sdk-mcuboot module file which uses the mcuboot files

@AntonZma
Copy link
Author

AntonZma commented Mar 3, 2026

Will be done within the following PR: nrfconnect/sdk-nrf#27150

@AntonZma AntonZma closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants