drivers: uart_nrfx_uarte: fix race in runtime device PM usage count#3901
Open
invoxiaamo wants to merge 1 commit intonrfconnect:mainfrom
Open
drivers: uart_nrfx_uarte: fix race in runtime device PM usage count#3901invoxiaamo wants to merge 1 commit intonrfconnect:mainfrom
invoxiaamo wants to merge 1 commit intonrfconnect:mainfrom
Conversation
If uarte_nrfx_irq_tx_disable is called, pm_device_runtime_put call responsibility is transfer to TXSTOPPED handling through disable_tx_irq = true; Yet, if uarte_nrfx_irq_tx_enable is called before TXSTOPPED finally triggers, the pm_device_runtime_put call is lost. Also protect uarte_nrfx_irq_tx_disable for race with irq. This fixes corrupted usage count on fast and repeated fixed RX+TX patterns. Signed-off-by: Arnaud Mouiche <arnaud.mouiche@invoxia.com>
Contributor
|
none Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If uarte_nrfx_irq_tx_disable is called, pm_device_runtime_put call responsibility is transfer to TXSTOPPED handling through
disable_tx_irq = true;
Yet, if uarte_nrfx_irq_tx_enable is called before TXSTOPPED finally triggers, the pm_device_runtime_put call is lost.
Also protect uarte_nrfx_irq_tx_disable for race with irq.
The corruption happened very easily @ 921600 bauds when transmitting small chunks (< 10bytes) repeatedly but not continuously, with RX also enabled.