Skip to content

Conversation

@nytamin
Copy link

@nytamin nytamin commented Sep 15, 2025

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a: Feature

New Behavior

Adds the health endpoints healtz & readyz, as described in the task SOFIE-3863

Affected areas

This PR affects no playout logic, but adds an opt-in http server to playout-gateway

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin requested a review from a team as a code owner September 15, 2025 07:39
# Conflicts:
#	packages/playout-gateway/package.json
#	packages/yarn.lock
@Julusian
Copy link

I think this would be good to enable by default when running in docker (not sure about dev)

It is possible to define the healthcheck in the dockerfile, which can then be used in simple docker-compose setups (I assume k8s could use it too?) https://docs.docker.com/reference/dockerfile/#healthcheck
I dont think we need to write this today (unless k8s can use it), but having the http port enabled ready for when someone else does want to write it would be beneficial, and save them the effort of figuring out how to rework this port config without breaking existing deployments

@nytamin nytamin merged commit b3d4c51 into release52 Oct 6, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants