chore(repo): update CONTRIBUTING.md #2443
Conversation
|
View your CI Pipeline Execution ↗ for commit e4e1a37.
☁️ Nx Cloud last updated this comment at |
isaacplmann
left a comment
isaacplmann
left a comment
There was a problem hiding this comment.
The changes you added are helpful.
It would be good to add a note near the beginning stating that people should file an issue before making a PR to make sure that their code changes make sense before they do the actual work.
| - Install Node.js | ||
| - Install yarn: https://classic.yarnpkg.com/en/docs/install | ||
| - Run yarn install in the root directory | ||
| - Install java: https://www.java.com/en/download/help/download_options.html |
There was a problem hiding this comment.
Would be helpful to list which version(s) to install
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
|
||
| ### How to find Nx Console logs | ||
|
|
||
| Regardless of your IDE, there might be relevant information in the `daemon.log` & `daemon-error.log` files. You can find their location by running `nx daemon --log`. </br> |
There was a problem hiding this comment.
The HTML closing tag </br> is not valid HTML. For line breaks, use either the self-closing tag <br/> or the shorter form <br>. Both are valid in HTML5 and will render correctly in most contexts.
| Regardless of your IDE, there might be relevant information in the `daemon.log` & `daemon-error.log` files. You can find their location by running `nx daemon --log`. </br> | |
| Regardless of your IDE, there might be relevant information in the `daemon.log` & `daemon-error.log` files. You can find their location by running `nx daemon --log`. <br/> |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
No description provided.