chore(repo): remove unused dependencies#3110
Conversation
|
View your CI Pipeline Execution ↗ for commit 16524b4
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We updated apps/vscode/project.json to mark @nx/powerpack-license as external in the esbuild config, preventing a bundle-time resolution failure caused by nx dynamically requiring this now-removed package. We also removed plugin:cypress/recommended from apps/generate-ui-v2-e2e/.eslintrc.json since eslint-plugin-cypress was removed from devDependencies, eliminating the ESLint startup failure. Together these changes align the build and lint configurations with the dependency cleanup in this PR.
Tip
✅ We verified this fix by re-running generate-ui-v2-e2e:lint, vscode:build:ci.
diff --git a/apps/generate-ui-v2-e2e/.eslintrc.json b/apps/generate-ui-v2-e2e/.eslintrc.json
index fe65c0cf..3c29ed1a 100644
--- a/apps/generate-ui-v2-e2e/.eslintrc.json
+++ b/apps/generate-ui-v2-e2e/.eslintrc.json
@@ -1,5 +1,5 @@
{
- "extends": ["plugin:cypress/recommended", "../../.eslintrc.json"],
+ "extends": ["../../.eslintrc.json"],
"ignorePatterns": ["!**/*", "dist/**/*"],
"overrides": [
{
diff --git a/apps/vscode/project.json b/apps/vscode/project.json
index 3dfac770..7ab3f3e5 100644
--- a/apps/vscode/project.json
+++ b/apps/vscode/project.json
@@ -27,6 +27,7 @@
"@angular-devkit/*",
"@nx/key",
"@nx/nx*",
+ "@nx/powerpack-license",
"*/nx.wasi.cjs"
],
"thirdParty": true,
Because this branch comes from a fork, it is not possible for us to apply fixes directly, but you can apply the changes locally using the available options below.
Apply changes locally with:
npx nx-cloud apply-locally oG8X-B8Tq
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
What changed
libs/shared/ui-components/package.jsonyarn.lockafter the manifest cleanupWhy
axiosis not a direct dependency in this repo; it only appears transitively through Nx-related packagesknip@typescript-eslint/eslint-plugin, was explicitly kept because removing it broke ESLint config resolution during verificationImpact
Validation
yarn install --mode=skip-buildNX_DAEMON=false yarn nx format:write --files=package.json,libs/shared/ui-components/package.json,yarn.lock --verboseNX_DAEMON=false yarn dlx knip --dependencies --reporter compact --no-exit-code