chore(repo): use @nx/maven to build @nx/maven#33412
chore(repo): use @nx/maven to build @nx/maven#33412
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit debcb4b
☁️ Nx Cloud last updated this comment at |
c1afe9d to
e5817c2
Compare
2811980 to
4085a8e
Compare
pnpm-lock.yaml
Outdated
| '@nx/maven': | ||
| specifier: 22.1.0-rc.2 | ||
| version: 22.1.0-rc.2(nx@22.1.0-rc.2(@swc-node/register@1.9.1(@swc/core@1.5.7(@swc/helpers@0.5.11))(@swc/types@0.1.7)(typescript@5.9.2))(@swc/core@1.5.7(@swc/helpers@0.5.11))) |
There was a problem hiding this comment.
Version mismatch detected: package.json specifies @nx/maven: 22.1.0-rc.3 but pnpm-lock.yaml has locked version 22.1.0-rc.2. This mismatch will cause the wrong version to be installed.
# Fix by running:
pnpm install
# This will update the lockfile to match package.jsonThe lockfile must be regenerated to match the version specified in package.json to ensure consistent installations across environments.
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
4085a8e to
2e912b4
Compare
.github/workflows/ci.yml
Outdated
| - name: Show project graph | ||
| run: npx nx show project nx-maven-plugin | jq .targets.test | ||
|
|
There was a problem hiding this comment.
for sure once debugging is done I'll remove it 👍
5892e1c to
16c58ad
Compare
9490e22 to
c0b803e
Compare
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| "_install": { | ||
| "command": "node scripts/run-native-target.js install nx-maven-plugin" | ||
| "mvn-install-with-retries": { | ||
| "command": "for i in {1..5}; do npx nx run nx-maven-plugin:mvn-install && exit 0; sleep 10; done; exit 1" |
There was a problem hiding this comment.
The command uses brace expansion {1..5} which is not POSIX compliant and is not supported by /bin/sh (dash) on Debian/Ubuntu systems. This will cause the loop to execute only once, effectively disabling the retry mechanism in CI environments that use dash as the default shell.
Fix by using an explicit list of numbers:
"command": "for i in 1 2 3 4 5; do npx nx run nx-maven-plugin:mvn-install && exit 0; sleep 10; done; exit 1"| "command": "for i in {1..5}; do npx nx run nx-maven-plugin:mvn-install && exit 0; sleep 10; done; exit 1" | |
| "command": "for i in 1 2 3 4 5; do npx nx run nx-maven-plugin:mvn-install && exit 0; sleep 10; done; exit 1" |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
7452a6e to
de17133
Compare
2881f3d to
d5541bc
Compare
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
Our analysis shows these test failures are unrelated to the Maven refactoring changes in this PR. The errors stem from a pre-existing @microsoft/api-extractor package resolution issue that also exists in the master branch, affecting Vite config loading across multiple E2E test suites. This is an environmental issue requiring dependency resolution fixes rather than code changes to this PR.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
Co-authored-by: MaxKless <MaxKless@users.noreply.github.com>
Includes maven plugin migration to 0.0.14. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d5541bc to
debcb4b
Compare
Current Behavior
there is an
installtarget calling./mvnwdirectlyExpected Behavior
we use the
@nx/mavenplugin for generating maven targets