Skip to content

Comments

chore(repo): use @nx/maven to build @nx/maven#33412

Open
MaxKless wants to merge 15 commits intomasterfrom
use-maven-plugin
Open

chore(repo): use @nx/maven to build @nx/maven#33412
MaxKless wants to merge 15 commits intomasterfrom
use-maven-plugin

Conversation

@MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Nov 7, 2025

Current Behavior

there is an install target calling ./mvnw directly

Expected Behavior

we use the @nx/maven plugin for generating maven targets

@MaxKless MaxKless requested review from a team, FrozenPandaz and vsavkin as code owners November 7, 2025 16:14
@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Jan 16, 2026 4:12pm

Request Review

@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit debcb4b
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6998446e20365d000881088e
😎 Deploy Preview https://deploy-preview-33412--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Nov 7, 2025

View your CI Pipeline Execution ↗ for commit debcb4b

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ⛔ Cancelled 1h 40m 3s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3m 4s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 7s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-20 13:09:29 UTC

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

pnpm-lock.yaml Outdated
Comment on lines 595 to 597
'@nx/maven':
specifier: 22.1.0-rc.2
version: 22.1.0-rc.2(nx@22.1.0-rc.2(@swc-node/register@1.9.1(@swc/core@1.5.7(@swc/helpers@0.5.11))(@swc/types@0.1.7)(typescript@5.9.2))(@swc/core@1.5.7(@swc/helpers@0.5.11)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version mismatch detected: package.json specifies @nx/maven: 22.1.0-rc.3 but pnpm-lock.yaml has locked version 22.1.0-rc.2. This mismatch will cause the wrong version to be installed.

# Fix by running:
pnpm install
# This will update the lockfile to match package.json

The lockfile must be regenerated to match the version specified in package.json to ensure consistent installations across environments.

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

Comment on lines 95 to 97
- name: Show project graph
run: npx nx show project nx-maven-plugin | jq .targets.test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure once debugging is done I'll remove it 👍

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit debcb4b
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/6998446e13f45f0008fb7e02
😎 Deploy Preview https://deploy-preview-33412--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

"_install": {
"command": "node scripts/run-native-target.js install nx-maven-plugin"
"mvn-install-with-retries": {
"command": "for i in {1..5}; do npx nx run nx-maven-plugin:mvn-install && exit 0; sleep 10; done; exit 1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command uses brace expansion {1..5} which is not POSIX compliant and is not supported by /bin/sh (dash) on Debian/Ubuntu systems. This will cause the loop to execute only once, effectively disabling the retry mechanism in CI environments that use dash as the default shell.

Fix by using an explicit list of numbers:

"command": "for i in 1 2 3 4 5; do npx nx run nx-maven-plugin:mvn-install && exit 0; sleep 10; done; exit 1"
Suggested change
"command": "for i in {1..5}; do npx nx run nx-maven-plugin:mvn-install && exit 0; sleep 10; done; exit 1"
"command": "for i in 1 2 3 4 5; do npx nx run nx-maven-plugin:mvn-install && exit 0; sleep 10; done; exit 1"

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.

@MaxKless MaxKless requested a review from a team as a code owner February 6, 2026 13:12
Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud has identified a possible root cause for your failed CI:

Our analysis shows these test failures are unrelated to the Maven refactoring changes in this PR. The errors stem from a pre-existing @microsoft/api-extractor package resolution issue that also exists in the master branch, affecting Vite config loading across multiple E2E test suites. This is an environmental issue requiring dependency resolution fixes rather than code changes to this PR.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants