-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(core): delegate db operations to daemon when enabled #33862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Nx Cloud AI Fix could not be generatedView your CI Pipeline Execution ↗ for commit 94e8cea
☁️ Nx Cloud last updated this comment at |
1804881 to
185aae4
Compare
185aae4 to
08ab57a
Compare
ea9e6fa to
79f051f
Compare
d8ec75e to
23b9a8c
Compare
f63abb6 to
d5fca67
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-33862-b75a9d8 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-33862-b75a9d8
To request a new release for this pull request, mention someone from the Nx team or the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
These changes fix the timeout error in e2e-release:e2e-ci--src/release-tag-pattern.test.ts by preventing daemon delegation during cache initialization. The test was timing out because assertCacheIsValid() attempted to delegate cacheCheckFsInSync() to the daemon, which may not be ready during e2e test setup, causing the async call to hang and exceed the 60-second timeout.
We verified this fix by re-running e2e-release:e2e-ci--src/release-tag-pattern.test.ts.
diff --git a/packages/nx/src/tasks-runner/cache.ts b/packages/nx/src/tasks-runner/cache.ts
index e9e4c861ab..48c861e14f 100644
--- a/packages/nx/src/tasks-runner/cache.ts
+++ b/packages/nx/src/tasks-runner/cache.ts
@@ -382,12 +382,9 @@ export class DbCache {
// hit issues. If we detect this, we can create a fallback db cache in the
// custom directory, and check if the entries are there when the main db
// cache misses.
- let isInSync: boolean;
- if (this.shouldDelegateToDaemon()) {
- isInSync = await daemonClient.cacheCheckFsInSync();
- } else {
- isInSync = this.cache.checkCacheFsInSync();
- }
+
+ // Don't delegate to daemon during initialization to avoid hanging if daemon isn't ready
+ const isInSync = this.cache.checkCacheFsInSync();
if (isCI() && !isInSync) {
const warningLines = [
Or Apply changes locally with:
npx nx-cloud apply-locally uQJH-ZsEb
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
18c1ea2 to
3ef87d7
Compare
3ef87d7 to
94e8cea
Compare
Delegates all DB operations to the daemon when enabled.