Skip to content

Conversation

@MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Dec 18, 2025

Current Behavior

running commands while the nx daemon is disabled will check the nx console status - which sends a message to the daemon and thus enables it.
This can cause weird race conditions.

Expected Behavior

As it's a non-critical check, we should only send messages to the daemon if it's running.

Related Issue(s)

Fixes #

@MaxKless MaxKless requested a review from a team as a code owner December 18, 2025 12:59
@MaxKless MaxKless requested a review from AgentEnder December 18, 2025 12:59
@vercel
Copy link

vercel bot commented Dec 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Jan 15, 2026 9:18am

@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit a75f609
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6968af284100bb0007183ad5
😎 Deploy Preview https://deploy-preview-33917--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Dec 18, 2025

View your CI Pipeline Execution ↗ for commit a75f609

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 20m 29s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 57s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 12s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-15 13:59:55 UTC

Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud has identified a possible root cause for your failed CI:

Our failing Maven e2e tests are encountering an external service issue where Spring Initializr (start.spring.io) now rejects Spring Boot 3.4.0 and requires >=3.5.0. This is unrelated to the daemon client changes in this PR and represents an environment_state failure caused by the external API updating its compatibility requirements.

No code changes were suggested for this issue.

🔂 A CI rerun has been triggered by adding an empty commit to this branch.

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@MaxKless MaxKless force-pushed the dont-start-daemon-for-console-check branch from e965f6a to a75f609 Compare January 15, 2026 09:11
@MaxKless MaxKless merged commit 1b12b39 into master Jan 15, 2026
20 of 21 checks passed
@MaxKless MaxKless deleted the dont-start-daemon-for-console-check branch January 15, 2026 15:15
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants