-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(release): special-case 0.x versions for semver bumps #34031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit a21dbc3
☁️ Nx Cloud last updated this comment at |
6c7e965 to
4f46e49
Compare
For 0.x versions, shift semver bump types down to follow the common convention where breaking changes bump minor, and new features bump patch: - major -> minor - premajor -> preminor - minor -> patch - preminor -> prepatch - patch -> patch (unchanged) This ensures that `nx release` with a breaking change on a 0.x package (e.g., 0.1.0) bumps to 0.2.0 instead of 1.0.0. Fixes NXC-3638
Add a new configuration option `adjustSemverBumpsForZeroMajorVersion` that controls whether semver bumps are adjusted for 0.x versions. When enabled: - 'major' bumps become 'minor' bumps for 0.x versions - 'minor' bumps become 'patch' bumps for 0.x versions - 'premajor' becomes 'preminor' for 0.x versions - 'preminor' becomes 'prepatch' for 0.x versions This option defaults to `false` to maintain backward compatibility with the existing behavior. A TODO comment marks this for switching to `true` by default in v23.
4f46e49 to
6639fc1
Compare
Co-authored-by: Coly010 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
Our PR changes only affect release/semver functionality but the failure occurs in Gradle e2e tests due to external service unavailability. The foojay Java toolchain provisioning service returned "503 Service Temporarily Unavailable" errors, preventing Gradle from downloading Java 21 required for the tests. This external infrastructure failure is unrelated to our code changes and requires waiting for the service to recover.
No code changes were suggested for this issue.
If the issue was transient, you can trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |

For 0.x versions, shift semver bump types down to follow the common
convention where breaking changes bump minor, and new features bump patch:
This ensures that
nx releasewith a breaking change on a 0.x package(e.g., 0.1.0) bumps to 0.2.0 instead of 1.0.0.
Fixes NXC-3638