cleanup(repo): avoid unnecessary project graph recomputations#34423
Open
leosvelperez wants to merge 3 commits intomasterfrom
Open
cleanup(repo): avoid unnecessary project graph recomputations#34423leosvelperez wants to merge 3 commits intomasterfrom
leosvelperez wants to merge 3 commits intomasterfrom
Conversation
leosvelperez
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 1dfe1a8
☁️ Nx Cloud last updated this comment at |
leosvelperez
force-pushed
the
repo/prevent-wrong-recomputations
branch
from
a26d737 to
825b00e
Compare
FrozenPandaz
approved these changes
Feb 18, 2026
Collaborator
FrozenPandaz
left a comment
FrozenPandaz
left a comment
There was a problem hiding this comment.
The other files are fine. Please remove the changes to .nxignore.
.nxignore
Outdated
| packages/nx/src/native/index.d.ts | ||
| packages/nx/src/native/native-bindings.js | ||
|
|
||
| # Workaround for ignore-files crate bug with prefix matching |
Collaborator
There was a problem hiding this comment.
We merged the fix for ignore-files
.nxignore
Outdated
| nx-dev/tutorial/**/templates | ||
|
|
||
| # Generated by napi-rs (outputs of build-native) | ||
| packages/nx/src/native/index.d.ts |
Collaborator
There was a problem hiding this comment.
Yes, these are generated but these are also important for hashing.
If we add it to .nxignore, then it will yield false positive cache hits.
Let's not make any changes to this file.
AgentEnder
force-pushed
the
repo/prevent-wrong-recomputations
branch
4 times, most recently
from
caf8654 to
849a43d
Compare
- temp-db*/ catches temp-db-cache, temp-db-task variants - *.config.timestamp* catches all config timestamp files (astro, vite, etc.) Prevents daemon recomputations from test/build artifacts.
- Ignore index.d.ts and native-bindings.js (napi-rs outputs) - Ignore **/target/ (Maven/Gradle build outputs) - a bug in the `ignore-files` crate cause them to be picked even though they are ignored in the root .gitignore file These files are build outputs, not inputs to the project graph. Prevents spurious daemon recomputations during builds.
Port lock files were being written to the source directory, triggering the daemon file watcher and causing unnecessary project graph recomputations during Cypress test runs. Move lock files to os.tmpdir()/nx-cypress-port-locks/ to avoid this.
leosvelperez
force-pushed
the
repo/prevent-wrong-recomputations
branch
from
849a43d to
1dfe1a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
start-dev-server.tsfile creates a port lock file next to the source codeThese all trigger watch file change events, which cause the project graph to be recomputed unnecessarily.
Expected Behavior
Output files should not trigger watch file change events. The project graph should not be recomputed unnecessarily.