fix(core): remove redundant allWorkspaceFiles from the project graph pipeline#34425
Open
leosvelperez wants to merge 2 commits intomasterfrom
Open
fix(core): remove redundant allWorkspaceFiles from the project graph pipeline#34425leosvelperez wants to merge 2 commits intomasterfrom
allWorkspaceFiles from the project graph pipeline#34425leosvelperez wants to merge 2 commits intomasterfrom
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit a076e36
☁️ Nx Cloud last updated this comment at |
leosvelperez
added
the
target: next major version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
allWorkspaceFiles(a flatFileData[]of every file in the workspace) is built, stored, copied, and passed through the project graph pipeline — even though no consumer uses it. The data is fully redundant withfileMap.projectFileMap+fileMap.nonProjectFiles. In the daemon, it's deep-copied on every graph serialization viacopyFileData()and rebuilt on every incremental update viabuildAllWorkspaceFiles().Expected Behavior
allWorkspaceFilesis removed from:retrieveWorkspaceFilesreturn valuebuildProjectGraphUsingProjectFileMapparametershydrateFileMap/getFileMap/storedAllWorkspaceFilesfileMapWithFilesdaemon state andSerializedProjectGraphinterfaceWorkspaceFileMapinterface andupdateFileMapreturn valueThis eliminates redundant allocations, copies, and retained references.
Native/Rust code is unaffected — it uses
rustReferences.allWorkspaceFiles(ExternalObject), which is a separate code path.