Fix not finding workspace project from deep imports on enforce module boundaries#34536
Open
Ryntak94 wants to merge 4 commits intonrwl:masterfrom
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/eslint-plugin/src/rules/enforce-module-boundaries.spec.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/src/rules/enforce-module-boundaries.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nx/enforce-module-boundarieswas not identifying the importing of an app if it was installed as a dependency in thepackage.jsonand was not listed in thepathsof the tsconfig.Also
targetProjectLocator.findImportInWorkspaceProjectswasn't finding projects in the workspace if they weren't namespaced and were using subpaths.Expected Behavior
targetProjectLocator.findImportInWorkspaceProjectsshould find projects even if they aren't namespaced and are using subpaths.@nx/enforce-module-boundariesshould error on importing apps even if they are not namespaced, installed as project dependencies, and don't exist in thepathsof the relevant tsconfig.Related Issue(s)
none (as far as I can tell)
Fixes #