Skip to content

fix(core): remove CRA migration logic from nx init#34912

Merged
jaysoo merged 1 commit intomasterfrom
NXC-4107
Mar 19, 2026
Merged

fix(core): remove CRA migration logic from nx init#34912
jaysoo merged 1 commit intomasterfrom
NXC-4107

Conversation

@jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 18, 2026

Current Behavior

nx init has a special code path for Create React App (CRA) projects that installs Vite-related dependencies incompatible with @nx/vite when Vite 8 is resolved, causing failures for npm workspaces.

CRA is essentially unused for years so there's no point to keep it around.

Expected Behavior

CRA projects are no longer special-cased in nx init. They flow through the normal npm repo path, which detects plugins like @nx/vite via the standard detectPlugins() mechanism.

Screenshot 2026-03-18 at 2 34 56 PM Screenshot 2026-03-18 at 2 35 01 PM Screenshot 2026-03-18 at 2 35 15 PM

Related Issue(s)

Closes NXC-4107

@jaysoo jaysoo requested a review from a team as a code owner March 18, 2026 18:37
@jaysoo jaysoo requested a review from leosvelperez March 18, 2026 18:37
@netlify
Copy link

netlify bot commented Mar 18, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 1094534
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69bc02df45334f000867626d
😎 Deploy Preview https://deploy-preview-34912--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 18, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 1094534
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69bc02de7881e400085da611
😎 Deploy Preview https://deploy-preview-34912--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Mar 18, 2026

View your CI Pipeline Execution ↗ for commit 1094534

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 51m 14s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 8s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 8s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-19 15:01:54 UTC

## Current Behavior
`nx init` has a special code path for Create React App (CRA) projects
that installs Vite-related dependencies incompatible with `@nx/vite`
when Vite 8 is resolved, causing failures for npm workspaces.

## Expected Behavior
CRA projects are no longer special-cased in `nx init`. They flow
through the normal npm repo path, which detects plugins like `@nx/vite`
via the standard `detectPlugins()` mechanism.

## Related Issue(s)
Fixes NXC-4107
@jaysoo jaysoo merged commit 1081dbd into master Mar 19, 2026
21 of 22 checks passed
@jaysoo jaysoo deleted the NXC-4107 branch March 19, 2026 20:38
FrozenPandaz pushed a commit that referenced this pull request Mar 20, 2026
## Current Behavior

`nx init` has a special code path for Create React App (CRA) projects
that installs Vite-related dependencies incompatible with `@nx/vite`
when Vite 8 is resolved, causing failures for npm workspaces.

CRA is essentially unused for years so there's no point to keep it
around.

## Expected Behavior

CRA projects are no longer special-cased in `nx init`. They flow through
the normal npm repo path, which detects plugins like `@nx/vite` via the
standard `detectPlugins()` mechanism.

<img width="1279" height="448" alt="Screenshot 2026-03-18 at 2 34 56 PM"
src="https://github.com/user-attachments/assets/17da3c6d-8aef-450f-baaa-6014e03cf41f"
/>

<img width="1280" height="432" alt="Screenshot 2026-03-18 at 2 35 01 PM"
src="https://github.com/user-attachments/assets/e02ccda5-9faf-428f-878d-348e4cc44d74"
/>

<img width="1270" height="821" alt="Screenshot 2026-03-18 at 2 35 15 PM"
src="https://github.com/user-attachments/assets/fdd99af5-db7e-422b-be42-a817c9dcefa2"
/>


## Related Issue(s)

Closes NXC-4107
FrozenPandaz pushed a commit that referenced this pull request Mar 20, 2026
## Current Behavior

`nx init` has a special code path for Create React App (CRA) projects
that installs Vite-related dependencies incompatible with `@nx/vite`
when Vite 8 is resolved, causing failures for npm workspaces.

CRA is essentially unused for years so there's no point to keep it
around.

## Expected Behavior

CRA projects are no longer special-cased in `nx init`. They flow through
the normal npm repo path, which detects plugins like `@nx/vite` via the
standard `detectPlugins()` mechanism.

<img width="1279" height="448" alt="Screenshot 2026-03-18 at 2 34 56 PM"
src="https://github.com/user-attachments/assets/17da3c6d-8aef-450f-baaa-6014e03cf41f"
/>

<img width="1280" height="432" alt="Screenshot 2026-03-18 at 2 35 01 PM"
src="https://github.com/user-attachments/assets/e02ccda5-9faf-428f-878d-348e4cc44d74"
/>

<img width="1270" height="821" alt="Screenshot 2026-03-18 at 2 35 15 PM"
src="https://github.com/user-attachments/assets/fdd99af5-db7e-422b-be42-a817c9dcefa2"
/>


## Related Issue(s)

Closes NXC-4107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants