Skip to content

Extend the control plane options to the public API#382

Merged
yankcrime merged 2 commits intomainfrom
nick/orc-48-api_controlplane_config
Mar 17, 2026
Merged

Extend the control plane options to the public API#382
yankcrime merged 2 commits intomainfrom
nick/orc-48-api_controlplane_config

Conversation

@yankcrime
Copy link
Member

@yankcrime yankcrime commented Mar 11, 2026

The end customer is best placed to ultimately decide on how big they need their control plane nodes to be, based on their workload and patterns.

Default behaviour remains the same, otherwise allow overriding the specification in the API.

The end customer is best place to ultimately decide on how big they need
their control plane nodes to be, based on their workload and patterns.

Default behaviour remains the same, otherwise allow overriding the
specification in the API.
@yankcrime yankcrime requested a review from spjmurray March 11, 2026 11:11
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.84%. Comparing base (a301fb2) to head (2301b3a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/server/handler/cluster/conversion.go 0.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #382      +/-   ##
========================================
- Coverage   4.50%   3.84%   -0.66%     
========================================
  Files         59      59              
  Lines       5754    5768      +14     
========================================
- Hits         259     222      -37     
- Misses      5457    5470      +13     
- Partials      38      76      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@spjmurray spjmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, and backwards compatible.

@spjmurray
Copy link
Contributor

Merge error
Base branch requires signed commits. Rebase merges cannot be automatically signed by GitHub

@yankcrime
Copy link
Member Author

@spjmurray Try again please 🙏

@yankcrime yankcrime merged commit 49e6790 into main Mar 17, 2026
9 checks passed
@yankcrime yankcrime deleted the nick/orc-48-api_controlplane_config branch March 17, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants