Exodus: I/O of time series data, field data, cell data#1550
Open
Intergalactyc wants to merge 10 commits intonschloe:mainfrom
Open
Exodus: I/O of time series data, field data, cell data#1550Intergalactyc wants to merge 10 commits intonschloe:mainfrom
Intergalactyc wants to merge 10 commits intonschloe:mainfrom
Conversation
…teps of data; allow for writing cell data
…fined dict order behavior)
…_sets functionality; note regarding lack of cell_sets analog
…ng backwards compatibility) as well as field data reading; exodus write: updated time inference logic
…bility), so that exodus read timestep specification works
… both points and cells, with fix to categorize to allow slightly more general 2d vector naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fairly significant overhaul to
_exodus.pyto provide the following features:timestepkwarg can either be an integer (default 0) to select a given timestep by index, or "all" to instead obtain a list with a Mesh for each timestep. Improved read performance by pre-fetching variable handles and disabling NetCDF auto-masking where not yet done.Minor changes were also made to
_helpers.pyto allow the additionaltimestepkwarg for read to be passed through (non-breaking).Backwards compatibility
Fully backwards compatible. All changes made are nonbreaking: call signature changes are only the addition of optional kwargs, and return values should be the same unless these kwargs are used.
Tests
Added four new tests to
test_exodus.pyto comprehensively test new features. These and all existing exodus tests pass.Relevant issues
writecan easily be adapted to full support for side sets as described. Node sets are already supported.Anyways, thanks @nschloe and everyone for this great tool; hopefully these changes can help someone.